include property writes in super-classes when reading a property in a sub-class

erik-krogh · erik-krogh · commit 1b6e1dbd13f7 · 2021-08-27T10:04:39.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll b/javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll
@@ -1591,7 +1591,7 @@ module DataFlow {
    */
   predicate localFieldStep(DataFlow::Node pred, DataFlow::Node succ) {
     exists(ClassNode cls, string prop |
-      pred = cls.getAReceiverNode().getAPropertyWrite(prop).getRhs() or
+      pred = cls.getADirectSuperClass*().getAReceiverNode().getAPropertyWrite(prop).getRhs() or
       pred = cls.getInstanceMethod(prop)
     |
       succ = cls.getAReceiverNode().getAPropertyRead(prop)

Original file line number	Diff line number	Diff line change
`@@ -1591,7 +1591,7 @@ module DataFlow {`
`1591`	`1591`	`*/`
`1592`	`1592`	`predicate localFieldStep(DataFlow::Node pred, DataFlow::Node succ) {`
`1593`	`1593`	`exists(ClassNode cls, string prop \|`
`1594`		`- pred = cls.getAReceiverNode().getAPropertyWrite(prop).getRhs() or`
	`1594`	`+ pred = cls.getADirectSuperClass*().getAReceiverNode().getAPropertyWrite(prop).getRhs() or`
`1595`	`1595`	`pred = cls.getInstanceMethod(prop)`
`1596`	`1596`	`\|`
`1597`	`1597`	`succ = cls.getAReceiverNode().getAPropertyRead(prop)`