Suggestion: reorder streams

[jaybawk]

Ran into a batch of files where the first steam was not video as it should be and is required for some plugins logic.

Using Tdarr_Plugin_00td_action_re_order_all_streams_v2 for this which checks if it's in the right order. If not it reorders the streams to be correct. If it is, just passes it through. So no hit unless it's incorrect.

If they aren't in the right order during the subtitle stage it will delete the video stream as it expects it to be first during the reorder subtitle streams step.

[Shadowalker125]

I wonder if this is why I've had some videos stop under the subtitles flow with file sizes being like 1mb or something. I had no idea what was happening.

[jaybawk]

That was the error I was encountering. Saw that video was on the 3rd stream and wasn't copied cause it assumes video is first. Took me a bit to figure out but I got there.

[Shadowalker125]

I already noticed this error in video transcoding and added a fix for that too #3 (comment)

[jaybawk]

Was just typing up about that one haha. Yeah I wonder if just doing this one step would be simpler and cleaner assuming the subtitle reorder step just strips all other video if its not the first stream.

[Shadowalker125]

You just have to remember to keep the modularity of the flow. Assume the subtitle can be skipped but video transcoding still happens. Almost makes me wish there was a prep step called by the controller flow before anything else.

[jaybawk]

That's true, I didn't put an insane amount of thought into the full process part. Just whats the issue and what's solving it.

[jordanlambrecht]

I'm going to create an initialization flow that runs a first pass that handles stuff like this + removing images etc. Any other suggestions as to what would go in it? Including upfront logic for determining if a video should even be processed.