persist/push: Avoid sending object properties not declared in input types (vuex-orm#120)

Author: John Rix

src/actions/fetch.ts

@@ -40,6 +40,7 @@ export default class Fetch extends Action {
         model,
         params.filter as Data,
         true,
+        undefined,
         Object.keys(params.filter)
       );
     }

src/actions/persist.ts

@@ -21,7 +21,12 @@ export default class Persist extends Action {
     if (id) {
       const model = this.getModelFromState(state!);
       const mutationName = Context.getInstance().adapter.getNameForPersist(model);
-      const oldRecord = model.getRecordWithId(id)!;
+
+      const oldRecord = model.baseModel
+        .query()
+        .withAllRecursive()
+        .where("$id", id)
+        .first()!;
 
       const mockReturnValue = model.$mockHook("persist", {
         id,

src/graphql/transformer.ts

@@ -10,6 +10,7 @@ import {
   singularize
 } from "../support/utils";
 import { ConnectionMode } from "../adapters/adapter";
+import { GraphQLType, GraphQLField } from "../support/interfaces";
 
 /**
  * This class provides methods to transform incoming data from GraphQL in to a format Vuex-ORM understands and
@@ -32,13 +33,15 @@ export default class Transformer {
     model: Model,
     data: Data,
     read: boolean,
+    inputType?: GraphQLType | null,
     whitelist?: Array<String>,
     outgoingRecords?: Map<string, Array<string>>,
     recursiveCall?: boolean
   ): Data {
     const context = Context.getInstance();
     const relations: Map<string, Relation> = model.getRelations();
     const returnValue: Data = {} as Data;
+    const inputFields = inputType ? inputType.inputFields : undefined;
     if (outgoingRecords === undefined) outgoingRecords = new Map<string, Array<string>>();
     if (recursiveCall === undefined) recursiveCall = false;
 
@@ -64,7 +67,8 @@ export default class Transformer {
           key,
           value,
           model,
-          whitelist
+          whitelist,
+          inputFields
         )
       ) {
         let relatedModel = Model.getRelatedModel(relations.get(key)!);
@@ -81,6 +85,7 @@ export default class Transformer {
                 v,
                 read,
                 undefined,
+                undefined,
                 outgoingRecords,
                 true
               );
@@ -102,6 +107,7 @@ export default class Transformer {
             value,
             read,
             undefined,
+            undefined,
             outgoingRecords,
             true
           );
@@ -207,14 +213,16 @@ export default class Transformer {
    * @param {any} value Value of the field.
    * @param {Model} model Model class which contains the field.
    * @param {Array<String>|undefined} whitelist Contains a list of fields which should always be included.
+   * @param {Array<GraphQLField>|undefined} schemaFields Contains a list of schema fields which are defined in the model input type for the mutation.
    * @returns {boolean}
    */
   public static shouldIncludeOutgoingField(
     forFilter: boolean,
     fieldName: string,
     value: any,
     model: Model,
-    whitelist?: Array<String>
+    whitelist?: Array<String>,
+    schemaFields?: Array<GraphQLField>
   ): boolean {
     // Always add fields on the whitelist.
     if (whitelist && whitelist.includes(fieldName)) return true;
@@ -225,6 +233,9 @@ export default class Transformer {
     // Ignore empty fields
     if (value === null || value === undefined) return false;
 
+    // Is the field in the mutation type field list, if provided?
+    if (schemaFields && !schemaFields.find(f => f.name === fieldName)) return false;
+
     // Include all eager save connections
     if (model.getRelations().has(fieldName)) {
       // We never add relations to filters.