Weird issue with ScottoFrog on Mac

[arlaneenalra]

I just finished a build of the ScottoFrog and was attempting to use it on a Mac. This worked fine everywhere but the terminal. In terminal it was sending two weird characters that came out as: 0xef9cb9 0xef9cb9 (Well the symbols those unicode bytes represent) everytime I hit the symbol toggle key.

In the QMK key tester, the pressing symbol would send the clear key which appears to be in the num-lock position on the displayed keyboard pattern.

(Green box)

Based on that, I checked the firmware and discovered

scottokeebs/ScottoFrog/PCB/QMK/custom_keys.c

Lines 3 to 9 in b6a4394

	// Force num lock always on
	bool led_update_user(led_t state) {
	if (!state.num_lock) {
	tap_code(KC_NUM_LOCK);
	}
	return true;
	}

// Force num lock always on
bool led_update_user(led_t state) {
  if (!state.num_lock) {
    tap_code(KC_NUM_LOCK);
  }
  return true;
}

For whatever reason, that appears to be what tripped it up. Removing that bit of code fixes the errant behavior in terminal. This might be a gotcha for other Mac users.

[joe-scotto]

I am unable to replicate this on MacOS or windows. On both the stock terminal and iTerm2 I don't get any weird stuff coming through. Symbol works as expected and so do the other layers. I also checked on a key tester and don't see the clear key coming through at all.

Can you give me the following to see if I can replicate?

1. OS Version
2. What terminal you are using
3. What keys are giving the issue