Skip to content

Commit 7a6ba65

Browse files
fix: set depends_on after task creation in test
The Task::new() doesn't accept depends_on parameter, so we need to set it after construction in the test.
1 parent 4f4eac1 commit 7a6ba65

2 files changed

Lines changed: 6 additions & 12 deletions

File tree

src/storage/backup.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ fn rotate_backups(backup_dir: &Path, max_backups: usize) -> Result<()> {
5757
let mut backups: Vec<PathBuf> = std::fs::read_dir(backup_dir)?
5858
.filter_map(|e| e.ok())
5959
.map(|e| e.path())
60-
.filter(|p| p.extension().map_or(false, |e| e == "db"))
60+
.filter(|p| p.extension().is_some_and(|e| e == "db"))
6161
.collect();
6262

6363
backups.sort();
@@ -77,7 +77,7 @@ fn last_backup_time(backup_dir: &Path) -> Option<std::time::SystemTime> {
7777
std::fs::read_dir(backup_dir)
7878
.ok()?
7979
.filter_map(|e| e.ok())
80-
.filter(|e| e.path().extension().map_or(false, |ext| ext == "db"))
80+
.filter(|e| e.path().extension().is_some_and(|ext| ext == "db"))
8181
.filter_map(|e| e.metadata().ok()?.modified().ok())
8282
.max()
8383
}

src/storage/sqlite.rs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ impl Storage for SqliteStorage {
460460
let conn = self.open()?;
461461
let mut stmt = conn.prepare("SELECT * FROM projects ORDER BY created_at")?;
462462
let projects = stmt
463-
.query_map([], |row| row_to_project(row))?
463+
.query_map([], row_to_project)?
464464
.collect::<rusqlite::Result<Vec<_>>>()
465465
.context("Failed to load projects")?;
466466
Ok(projects)
@@ -549,7 +549,7 @@ impl Storage for SqliteStorage {
549549
let conn = self.open()?;
550550
let mut stmt = conn.prepare("SELECT * FROM resources ORDER BY created_at")?;
551551
let resources = stmt
552-
.query_map([], |row| row_to_resource(row))?
552+
.query_map([], row_to_resource)?
553553
.collect::<rusqlite::Result<Vec<_>>>()
554554
.context("Failed to load resources")?;
555555
Ok(resources)
@@ -718,14 +718,8 @@ mod tests {
718718
fn test_task_dependencies() {
719719
let (storage, _tmp) = make_storage();
720720
let t1 = Task::new("Task 1".into(), Priority::Medium, vec![], None, None, None);
721-
let t2 = Task::new(
722-
"Task 2".into(),
723-
Priority::Medium,
724-
vec![t1.uuid],
725-
None,
726-
None,
727-
None,
728-
);
721+
let mut t2 = Task::new("Task 2".into(), Priority::Medium, vec![], None, None, None);
722+
t2.depends_on = vec![t1.uuid];
729723
storage.save(&[t1.clone(), t2.clone()]).unwrap();
730724
let loaded = storage.load().unwrap();
731725
let loaded_t2 = loaded.iter().find(|t| t.uuid == t2.uuid).unwrap();

0 commit comments

Comments
 (0)