Http::$cookies do not handle duplicate calls correctly

[JJCLane]

Great job on AdapterMan so far! I've been experimenting with this and trying to narrow down some unusual behaviour.

Currently the handling of cookies appends any calls of setCookie to the static $cookies array, but this leads to a situation where multiple calls with the same name ends up returning multiple Set-cookie headers which differs from normal PHP execution.

E.g.

setCookie('myCookie', 1);
setCookie('myCookie', 2);

Normal PHP response

Set-Cookie: myCookie=2; path=/; HttpOnly; SameSite=Strict

AdapterMan

Set-Cookie: myCookie=1; path=/; HttpOnly; SameSite=Strict
Set-Cookie: myCookie=2; path=/; HttpOnly; SameSite=Strict

Relevant code:

AdapterMan/src/Http.php

Line 247 in a7c6159

static::$cookies[] = 'Set-Cookie: ' . $name . '=' . \rawurlencode($value)

AdapterMan/src/Http.php

Line 186 in a7c6159

static::$cookies[] = $content;

[joanhey]

Good catch !!
I'll try to fix it this Christmas and add a test.

But the final solution is to use the original php functions, we send a PR to php-src. php/php-src#16145
When this PR is merged we don't need to disable functions, and use directly the php functions.