chore: use t.error expectation

Author: Johannes J. Schmidt

test/test-configure.js

@@ -4,10 +4,10 @@ var configure = require('../lib/configure')
 
 test('configure', function(t) {
   helper.clearConfig(function(error) {
-    t.notOk(error, 'no error occured')
+    t.error(error, 'no error occured')
 
     configure(helper.couch, helper.source, {}, function(error, responses) {
-      t.notOk(error, 'no error occured')
+      t.error(error, 'no error occured')
 
       helper.couch.request({
         path: '_config/couchdb-bootstrap/foo'

test/test-couchdb-bootstrap.js

@@ -4,7 +4,7 @@ var bootstrap = require('..')
 
 test('basics', function(t) {
   bootstrap(helper.url, helper.source, function(error, response) {
-    t.notOk(error, 'no error occured')
+    t.error(error, 'no error occured')
 
     t.end()
   })

test/test-map-db-name-option.js

@@ -8,7 +8,7 @@ test('options.mapDbName is object', function(t) {
       'test-couchdb-bootstrap': 'custom-db-name'
     }
   }, function(error, response) {
-    t.notOk(error, 'no error occured')
+    t.error(error, 'no error occured')
 
     t.ok(response.secure['custom-db-name'].ok, 'creates security in db with custom name')
     t.ok(response.push['custom-db-name'], 'pushes docs to db with custom name')
@@ -21,7 +21,7 @@ test('options.mapDbName is function', function(t) {
   bootstrap(helper.url, helper.source, {
     mapDbName: function (name) { return name.replace('test', 'foobar') }
   }, function(error, response) {
-    t.notOk(error, 'no error occured')
+    t.error(error, 'no error occured')
 
     t.ok(response.secure['foobar-couchdb-bootstrap'], 'creates security in db with custom name')
     t.ok(response.push['foobar-couchdb-bootstrap'], 'pushes docs to db with custom name')

test/test-push.js

@@ -4,10 +4,10 @@ var push = require('../lib/push')
 
 test('push docs', function(t) {
   helper.setup(function(error) {
-    t.notOk(error, 'no error occured')
+    t.error(error, 'no error occured')
 
     push(helper.couch, helper.source, {}, function(error, response) {
-      t.notOk(error, 'no error occured')
+      t.error(error, 'no error occured')
 
       Object.keys(helper.docs).forEach(function(db) {
         t.ok(db in response, db + ' included')

test/test-secure.js

@@ -8,10 +8,10 @@ function setup(callback) {
 
 test('setup database securities', function(t) {
   setup(function(error) {
-    t.notOk(error, 'no error occured')
+    t.error(error, 'no error occured')
 
     secure(helper.couch, helper.source, {}, function(error, responses) {
-      t.notOk(error, 'no error occured')
+      t.error(error, 'no error occured')
 
       helper.dbnames.forEach(function(dbname) {
         t.ok(responses[dbname].ok, 'response is ok')

test/test-utils.js

@@ -2,16 +2,16 @@ var test = require('tape')
 var utils = require('../lib/utils')
 
 test('group by database', function(t) {
-  utils.groupByDatabase('foo', function(err, result) {
-    t.notOk(err, 'no error occured')
+  utils.groupByDatabase('foo', function(error, result) {
+    t.error(error, 'no error occured')
     t.ok(result.foo === 'bar', 'result is ok')
     t.end()
   })(null, 'bar')
 });
 
 test('group by database proxies error', function(t) {
-  utils.groupByDatabase('foo', function(err, result) {
-    t.ok(err, 'expected error occured')
+  utils.groupByDatabase('foo', function(error, result) {
+    t.ok(error, 'expected error occured')
     t.end()
   })(new Error('boom'))
 });