chore: rubocopp-ed

Author: jmatsu

lib/apkstats/plugin.rb

@@ -68,6 +68,7 @@ module Danger
   #
   class DangerApkstats < Plugin
     class Error < StandardError; end
+    class MisconfigurationError < Error; end
 
     # @deprecated this field have no effect
     COMMAND_TYPE_MAP = {
@@ -115,8 +116,6 @@ def apk_filepath=(value)
     # @return [String, NilClass] Your base apk filepath.
     attr_reader :apk_filepath
 
-    # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-
     # Get stats of two apk files and calculate diffs between them.
     #
     # @param [String, Pathname] other_apk_filepath your old apk
@@ -162,7 +161,7 @@ def summary
     def calculate_diff(other_apk_filepath:)
       ensure_apk_filepath!
 
-      base_apk_info = Apkstats::Entity::ApkInfo.new(command: apkanalyzer_command, apk_filepath: apk_filepath),
+      base_apk_info = Apkstats::Entity::ApkInfo.new(command: apkanalyzer_command, apk_filepath: apk_filepath)
       other_apk_info = Apkstats::Entity::ApkInfo.new(command: apkanalyzer_command, apk_filepath: other_apk_filepath)
       diff_apk_info = Apkstats::Entity::ApkInfoDiff.new(base: base_apk_info, other: other_apk_info)
 
@@ -173,8 +172,6 @@ def calculate_diff(other_apk_filepath:)
       }
     end
 
-    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
-
     # Show the file size of your apk file.
     #
     # @return [Fixnum] return positive value if exists, otherwise -1.
@@ -296,7 +293,7 @@ def on_error(err)
     end
 
     def ensure_apk_filepath!
-      raise "apk apk_filepath must be specified" if apk_filepath.nil? || !File.file?(apk_filepath)
+      raise MisconfigurationError, "apk_filepath must be specified" if apk_filepath.nil? || !File.file?(apk_filepath)
     end
 
     def process

lib/apkstats/reporter/apk_comparison.rb

@@ -1,14 +1,13 @@
+# frozen_string_literal: true
 
 module Apkstats::Reporter
-
   # @!attribute [r] base_apk_info
   #   @return [Apkstats::Entity::ApkInfo]
   # @!attribute [r] other_apk_info
   #   @return [Apkstats::Entity::ApkInfo]
   # @!attribute [r] diff_apk_info
   #   @return [Apkstats::Entity::ApkInfoDiff]
   class ApkComparison
-
     attr_reader :base_apk_info, :other_apk_info, :diff_apk_info
 
     # @param base_apk_info [Apkstats::Entity::ApkInfo] an apk info
@@ -19,6 +18,8 @@ def initialize(base_apk_info:, other_apk_info:)
       @diff_apk_info = Apkstats::Entity::ApkInfoDiff.new(base: base_apk_info, other: other_apk_info)
     end
 
+    # rubocop:disable Metrics/AbcSize
+
     # @return [String] markdown text
     def generate_markdown
       base = base_apk_info.to_h
@@ -72,6 +73,8 @@ def generate_markdown
       lines.flatten.join("\n") << "\n" # \n is required for the backward compatibility
     end
 
+    # rubocop:enable Metrics/AbcSize
+
     def min_sdk_change(before_value:, after_value:)
       return [] if before_value.nil? || after_value.nil?
 
@@ -124,7 +127,7 @@ def itemize_values_diff(name:, diff:)
     def itemize_with_label(label:, items:)
       return [] if items.empty?
 
-      "#{label} | #{items.map { |item| "- #{item}" }.join("<br>")}"
+      "#{label} | #{items.map { |item| "- #{item}" }.join('<br>')}"
     end
   end
-end
+end

lib/apkstats/reporter/apk_summary.rb

@@ -1,5 +1,6 @@
-module Apkstats::Reporter
+# frozen_string_literal: true
 
+module Apkstats::Reporter
   # @!attribute [r] apk_info
   #   @return [Apkstats::Entity::ApkInfo]
   class ApkSummary
@@ -13,7 +14,7 @@ class ApkSummary
       target_sdk: "Target Sdk",
       method_reference_count: "Method Reference Count",
       dex_count: "Dex File Count"
-    }
+    }.freeze
 
     attr_reader :apk_info
 
@@ -55,4 +56,4 @@ def generate_markdown
       lines.join("\n")
     end
   end
-end
+end

spec/apkstats_spec.rb

@@ -26,7 +26,7 @@ module Danger
         end
 
         context "unless apk_filepath is specified" do
-          it { expect(apkstats.compare_with(apk_other1, do_report: true)).to be_falsey }
+          it { expect { apkstats.compare_with(apk_other1, do_report: true) }.to raise_error(Danger::DangerApkstats::MisconfigurationError) }
         end
 
         context "otherwise" do

spec/reporter/apk_comparison_spec.rb

@@ -10,14 +10,14 @@
   let(:apk_filepath) { fixture_path.join("app-base.apk") }
   let(:other_apk_filepath) { fixture_path.join("app-other1.apk") }
 
-  describe '#generate_markdown' do
-    subject {
+  describe "#generate_markdown" do
+    subject do
       Apkstats::Reporter::ApkComparison.new(
         base_apk_info: base_apk_info,
         other_apk_info: other_apk_info
       ).generate_markdown
-    }
+    end
 
     it { is_expected.to eq(File.read(fixture_path.join("apk_comparison_of_base_and_other1.md"))) }
   end
-end
+end

spec/reporter/apk_summary_spec.rb

@@ -9,12 +9,12 @@
   let(:apk_base_filepath) { fixture_path.join("app-base.apk") }
   let(:apk_other1_filepath) { fixture_path.join("app-other1.apk") }
 
-  describe '#generate_markdown' do
-    subject {
+  describe "#generate_markdown" do
+    subject do
       Apkstats::Reporter::ApkSummary.new(
-        apk_info: apk_info,
+        apk_info: apk_info
       ).generate_markdown
-    }
+    end
 
     let(:apk_filepath) { apk_base_filepath }
 
@@ -26,4 +26,4 @@
       it { is_expected.to eq(File.read(fixture_path.join("apk_summary_of_other1.md"))) }
     end
   end
-end
+end