From a434d628c8c1bbc9adb234e47b88633b28d3f7d2 Mon Sep 17 00:00:00 2001 From: Jianfeng Mao <4297243+jmao-denver@users.noreply.github.com> Date: Mon, 13 Jan 2025 13:59:30 -0700 Subject: [PATCH] fix: Increase timeout to almost guarantee 2 PUG cycles to eliminate random test failures (#6560) random failures on the 2 test cases have been seen in CI/nightly recently. --- py/server/tests/test_table_data_service.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/py/server/tests/test_table_data_service.py b/py/server/tests/test_table_data_service.py index 28843d0a332..359b7f51652 100644 --- a/py/server/tests/test_table_data_service.py +++ b/py/server/tests/test_table_data_service.py @@ -346,8 +346,8 @@ def test_partition_sub_failure(self): backend.sub_new_partition_fail_test = True table = data_service.make_table(TableKeyImpl("test"), refreshing=True) with self.assertRaises(Exception) as cm: - # failure_cb will be called in the background thread after 2 PUG cycles - self.wait_ticking_table_update(table, 600, 2) + # failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough + self.wait_ticking_table_update(table, 600, 3) self.assertTrue(table.j_table.isFailed()) def test_partition_size_sub_failure(self): @@ -358,8 +358,8 @@ def test_partition_size_sub_failure(self): backend.sub_partition_size_fail_test = True table = data_service.make_table(TableKeyImpl("test"), refreshing=True) with self.assertRaises(Exception) as cm: - # failure_cb will be called in the background thread after 2 PUG cycles - self.wait_ticking_table_update(table, 600, 2) + # failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough + self.wait_ticking_table_update(table, 600, 3) self.assertTrue(table.j_table.isFailed())