You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Revert "Rollup merge of rust-lang#134209 - onur-ozkan:check-skip-paths, r=jieyouxu"
Unfortunately, the preset logic is not quite right because `Step`s are
allowed to register arbitrary *aliases* (e.g. `library/test` is aliases
to `test`), which means that we incorrectly warn on
```
./x test --exclude test
```
producing
```
WARNING: '/home/joe/repos/rust/test' does not exist.
```
even though this alias (`test`) is indeed a known and handled
`--exclude` filter.
A proper fix will need to do something like "collect all eligible
`Step`s then check `should_run(exclude)`" in order to determine if the
exclude filter will trigger for the steps. (Courtesy of jyn pointing
this out.)
This reverts commit 6cf13b0, reversing
changes made to 2846699.
0 commit comments