From 68ce1e871cbcd90789f462524ec0943bfee2ff0b Mon Sep 17 00:00:00 2001 From: Eric Lunderberg Date: Thu, 13 Apr 2023 11:37:34 -0500 Subject: [PATCH] [AOT] Fix warning on dropping const in TVMAotExecutor_GetInputName (#14529) Prior to this commit, the `TVMAotExecutor_GetInputName` function accepted a `char** name` output parameter. When used, assignment of a `const char*` into `*name` dropped the `const`, resulting in a warning. Changing the argument type to `const char**` (pointer to a mutable pointer to a `const char`) resolves this warning. --- include/tvm/runtime/crt/aot_executor.h | 2 +- src/runtime/crt/aot_executor/aot_executor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tvm/runtime/crt/aot_executor.h b/include/tvm/runtime/crt/aot_executor.h index 4783adec8eae..693a66c3ae04 100644 --- a/include/tvm/runtime/crt/aot_executor.h +++ b/include/tvm/runtime/crt/aot_executor.h @@ -100,7 +100,7 @@ int TVMAotExecutor_GetInputIndex(TVMAotExecutor* executor, const char* name); * \param name Output for retrieving name. * \return Pointer to input name in `name`. */ -int TVMAotExecutor_GetInputName(TVMAotExecutor* executor, int index, char** name); +int TVMAotExecutor_GetInputName(TVMAotExecutor* executor, int index, const char** name); /*! * \brief Run the generated program. diff --git a/src/runtime/crt/aot_executor/aot_executor.c b/src/runtime/crt/aot_executor/aot_executor.c index 8a47bb008bf0..9e733c21c3ab 100644 --- a/src/runtime/crt/aot_executor/aot_executor.c +++ b/src/runtime/crt/aot_executor/aot_executor.c @@ -82,7 +82,7 @@ int TVMAotExecutor_GetInputIndex(TVMAotExecutor* executor, const char* name) { return rv; } -int TVMAotExecutor_GetInputName(TVMAotExecutor* executor, int index, char** name) { +int TVMAotExecutor_GetInputName(TVMAotExecutor* executor, int index, const char** name) { const TVMMetadata* md = executor->metadata; *name = md->inputs[index].name; return 0;