internal: add some lib folders to tests (#29697)

Author: mshima

lib/command/generator-command.spec.ts

@@ -20,12 +20,6 @@ const dummyMeta = {
 };
 
 class CommandGenerator extends BaseApplicationGenerator {
-  _context: any = {};
-
-  get context() {
-    return this._context;
-  }
-
   constructor(args: any, opts: any, features: any) {
     super(args, opts, { ...features, jhipsterBootstrap: false });
     this.customLifecycle = true;
@@ -100,7 +94,7 @@ describe('generator commands', () => {
           expectGeneratorTestOption().toBe(value);
         }
 
-        if (scope !== 'context') {
+        if (!['application', 'context', 'storage', 'blueprint'].includes(scope)) {
           expectContextTestOption().toBeUndefined();
         } else if (Array.isArray(value)) {
           expectContextTestOption().toEqual(value);

lib/command/lookup-commands-configs.spec.ts

@@ -31,7 +31,7 @@ describe('jdl options', () => {
     }
 
     if (!choices) {
-      if (['routes'].includes(optionName)) {
+      if (['routes', 'appsFolders'].includes(optionName)) {
         // Option is manually tested.
         continue;
       }

lib/jdl-config/jhipster-jdl-config.spec.ts

@@ -1,12 +1,21 @@
 import { describe, expect, it } from 'esmocha';
 import { lookupCommandsConfigs } from '../command/lookup-commands-configs.js';
+import type { JDLApplicationConfig } from '../jdl/core/types/parsing.js';
 import { buildJDLApplicationConfig, getDefaultJDLApplicationConfig } from './jhipster-jdl-config.js';
 
 describe('getDefaultJDLApplicationConfig()', () => {
-  it('should return the default JDL application config', async () => {
+  let discoveredConfigs: JDLApplicationConfig;
+
+  before(async () => {
     const configs = await lookupCommandsConfigs();
-    const discoveredConfigs = buildJDLApplicationConfig(Object.fromEntries(Object.entries(configs).filter(([_key, value]) => value.jdl)));
+    discoveredConfigs = buildJDLApplicationConfig(Object.fromEntries(Object.entries(configs).filter(([_key, value]) => value.jdl)));
+  });
+
+  it('should return the default JDL application config', async () => {
     expect(getDefaultJDLApplicationConfig()).toMatchObject(discoveredConfigs);
+  });
+
+  it.skip('should match snapshot', async () => {
     expect(getDefaultJDLApplicationConfig()).toMatchSnapshot();
   });
 });

lib/jhipster/default-application-options.spec.ts

@@ -59,8 +59,8 @@ describe('jdl - DefaultApplicationOptions', () => {
       it('should set the client theme option to none', () => {
         expect(options.clientTheme).to.equal('none');
       });
-      it('should set the client theme variant option to none', () => {
-        expect(options.clientThemeVariant).to.equal('');
+      it('should set the client theme variant option to undefined', () => {
+        expect(options.clientThemeVariant).to.be.undefined;
       });
       it('should set withAdminUI option to true', () => {
         expect(options.withAdminUi).to.be.true;
@@ -139,8 +139,8 @@ describe('jdl - DefaultApplicationOptions', () => {
       it('should set the client theme option to none', () => {
         expect(options.clientTheme).to.equal('none');
       });
-      it('should set the client theme variant option to none', () => {
-        expect(options.clientThemeVariant).to.equal('');
+      it('should set the client theme variant option to undefined', () => {
+        expect(options.clientThemeVariant).to.be.undefined;
       });
       it('should set the withAdminUi option to true', () => {
         expect(options.withAdminUi).to.be.true;
@@ -334,9 +334,6 @@ describe('jdl - DefaultApplicationOptions', () => {
       it('should set the languages option to an empty array', () => {
         expect(options.languages).to.be.eql([]);
       });
-      it('should set the package folder to com/mycompany/myapp', () => {
-        expect(options.packageFolder).to.equal('com/mycompany/myapp');
-      });
       it('should set the package name to com.mycompany.myapp', () => {
         expect(options.packageName).to.equal('com.mycompany.myapp');
       });
@@ -366,19 +363,6 @@ describe('jdl - DefaultApplicationOptions', () => {
         expect(packageNameOption).to.equal('a.b.c.d');
       });
     });
-    describe('when there is no package folder option but only a package name', () => {
-      let packageFolderOption;
-
-      before(() => {
-        packageFolderOption = getDefaultConfigForNewApplication({
-          packageName: 'a.b.c.d',
-        }).packageFolder;
-      });
-
-      it('should set the package name accordingly', () => {
-        expect(packageFolderOption).to.equal('a/b/c/d');
-      });
-    });
     describe('when the client framework option is angular', () => {
       let clientFrameworkOption;
 

lib/jhipster/deployment-options.spec.ts

@@ -49,14 +49,7 @@ describe('jdl - DeploymentOptions', () => {
     describe('defaults', () => {
       describe('when passing no args', () => {
         it('should return docker deployment config', () => {
-          expect(Options.defaults()).to.eql({
-            appsFolders: [],
-            clusteredDbApps: [],
-            directoryPath: '../',
-            gatewayType: 'SpringCloudGateway',
-            monitoring: 'no',
-            serviceDiscoveryType: 'consul',
-          });
+          expect(() => Options.defaults()).to.throw(/^Deployment type is required$/);
         });
       });
       describe('when passing kubernetes as arg', () => {
@@ -72,6 +65,7 @@ describe('jdl - DeploymentOptions', () => {
             monitoring: 'no',
             serviceDiscoveryType: 'consul',
             ingressDomain: '',
+            ingressType: 'nginx',
             istio: false,
             kubernetesNamespace: 'default',
             kubernetesServiceType: 'LoadBalancer',

lib/jhipster/field-types.spec.ts

@@ -51,22 +51,6 @@ describe('jdl - FieldTypes', () => {
       });
     });
   });
-  describe('getIsType', () => {
-    describe('when passing an invalid argument', () => {
-      it('should fail', () => {
-        expect(() => {
-          // @ts-expect-error
-          fieldTypes.getIsType(null);
-        }).to.throw(/^The passed type must not be nil\.$/);
-        expect(() => {
-          // @ts-expect-error
-          fieldTypes.getIsType(null, () => {
-            // do nothing
-          });
-        }).to.throw(/^The passed type must not be nil\.$/);
-      });
-    });
-  });
   describe('hasValidation', () => {
     describe('when passing an invalid argument', () => {
       it('should fail', () => {

lib/testing/__snapshots__/helpers.spec.ts.snap

@@ -56,6 +56,7 @@ exports[`helpers run using withJHipsterGenerators should register jhipster gener
   "jhipster:kubernetes",
   "jhipster:kubernetes-helm",
   "jhipster:kubernetes-knative",
+  "jhipster:kubernetes:bootstrap",
   "jhipster:languages",
   "jhipster:liquibase",
   "jhipster:maven",
@@ -140,6 +141,7 @@ exports[`helpers runJHipster defaults should register jhipster generators namesp
   "jhipster:kubernetes",
   "jhipster:kubernetes-helm",
   "jhipster:kubernetes-knative",
+  "jhipster:kubernetes:bootstrap",
   "jhipster:languages",
   "jhipster:liquibase",
   "jhipster:maven",
@@ -224,6 +226,7 @@ exports[`helpers runJHipster with useDefaultMocks should register jhipster gener
   "jhipster:kubernetes",
   "jhipster:kubernetes-helm",
   "jhipster:kubernetes-knative",
+  "jhipster:kubernetes:bootstrap",
   "jhipster:languages",
   "jhipster:liquibase",
   "jhipster:maven",

package.json

@@ -114,14 +114,13 @@
     "jsdoc": "jsdoc --configure jsdoc-conf.json",
     "lint": "npm run eslint && npm run ejslint",
     "lint-fix": "npm run eslint -- --fix && npm run prettier:format",
-    "mocha-test": "esmocha lib/jdl --no-insight --forbid-only --parallel --max-old-space-size=4096",
     "prepare": "npm run build",
     "prettier:check": "prettier --check \"{,**/}*.{js,ts,cjs,mjs,cts,mts,json,md,yml,java}\"",
     "prettier:format": "prettier --write \"{,**/}*.{js,ts,cjs,mjs,cts,mts,json,md,yml,java}\"",
     "pretest": "npm run lint && npm run check-types",
-    "test": "npm run mocha-test test generators cli .blueprint",
+    "test": "esmocha test generators cli .blueprint lib/jdl lib/testing lib/jhipster lib/utils --forbid-only",
     "update-snapshot": "esmocha --no-insight --no-parallel --update-snapshot --",
-    "update-snapshots": "esmocha lib/jdl generators cli .blueprint --update-snapshot --no-insight --forbid-only"
+    "update-snapshots": "esmocha test generators cli .blueprint lib/jdl lib/testing lib/jhipster lib/utils --forbid-only --update-snapshot --enable-source-maps"
   },
   "overrides": {
     "ejs-lint": {