New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve original offset when parsing SM files #8

Open

jhaco opened this issue Nov 11, 2023 · 0 comments

Labels

enhancement future improvements

Owner

jhaco commented Nov 11, 2023

Current:

When parsing data from an SM file, the tool bakes in offset time into the rest of the note data. This was needed to work with StepCOVNet, since it doesn't consider offset timings using current methods.
When parsing an SM file, and rewriting back to a different SM file, it's highly possible that the note colors have changed due to them being placed differently with the offset baked in.

Path Forward:

Could be tricky, but I could probably add in a flag to not bake in offset time and preserve original data while extracting note timings. Depends on whether this is needed with how current convolution methods only consider timings...

jhaco added enhancement future improvements labels

jhaco changed the title ~~Preserve original offset when parsing SM files~~ preserve original offset when parsing SM files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment