Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are too slow #3

Open
jfischoff opened this issue Oct 9, 2014 · 6 comments
Open

tests are too slow #3

jfischoff opened this issue Oct 9, 2014 · 6 comments

Comments

@jfischoff
Copy link
Owner

No description provided.

@ericpashman
Copy link
Collaborator

Have you run the tests to completion to verify that they actually pass? If not, I have them running now and will let them keep going. ...

I know test-framework supports running tests in parallel, by the way, but I don't know how to run them through Cabal. It might be as easy as using the -j flag.

@jfischoff
Copy link
Owner Author

Have you run the tests to completion to verify that they actually pass? If not, I have them running now and will let them keep going. ...

No I haven't. I also should add a note that the approx comparison delta is really large and doing this approx comparison is probably not the right way to deal with Doubles, but I don't know any alternative ATM.

I know test-framework supports running tests in parallel, by the way, but I don't know how to run them through Cabal. It might be as easy as using the -j flag.

Interesting. I don't really care if we use the cabal test stuff. It might be better to have a separate cabal file in the test directory that makes an executable. Then we could definitely run them in parallel. Also we should use tasty.

@ericpashman
Copy link
Collaborator

I'd prefer to use tasty too.

@jfischoff
Copy link
Owner Author

I'd prefer to use tasty too.

Added here: #6

@ericpashman
Copy link
Collaborator

Just FYI, I let the tests run to completion and everything passed:

cabal test -j4
Test suite tests: PASS
Test suite logged to: dist/test/maxent-0.7-tests.log
1 of 1 test suites (1 of 1 test cases) passed.

So the tests in the harness check out anyway.

@jfischoff
Copy link
Owner Author

Nice

On Fri, Oct 10, 2014 at 12:44 PM, Eric Pashman [email protected]
wrote:

Just FYI, I let the tests run to completion and everything passed:

cabal test -j4
Test suite tests: PASS
Test suite logged to: dist/test/maxent-0.7-tests.log
1 of 1 test suites (1 of 1 test cases) passed.

So the tests in the harness check out anyway.


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants