Improve tests (#1134)

Author: adamshiervani

scripts/test_local_update.sh

@@ -72,9 +72,39 @@ if [ -z "$DEV_MACHINE_IP" ]; then
     exit 1
 fi
 
+# SSH helper function
+sshdev() {
+    ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no "root@$DEVICE_IP" "$@"
+}
+
 # Calculate binary SHA256
 BINARY_SHA256=$(shasum -a 256 "$BINARY_PATH" | awk '{print $1}')
 
+# Deploy binary to device
+echo -e "${CYAN}Deploying binary to device...${NC}"
+sshdev "cat > /userdata/jetkvm/jetkvm_app.update" < "$BINARY_PATH"
+sshdev "reboot"
+
+echo -e "${YELLOW}Waiting for device to reboot...${NC}"
+sleep 30
+
+# Wait for device to come back online
+for i in {1..30}; do
+    if ping -c 1 -W 2 "$DEVICE_IP" >/dev/null 2>&1; then
+        break
+    fi
+    sleep 2
+done
+
+# Wait for web interface to be ready
+for i in {1..30}; do
+    if curl -s --max-time 5 "http://$DEVICE_IP" >/dev/null 2>&1; then
+        echo -e "${GREEN}Device is ready${NC}"
+        break
+    fi
+    sleep 2
+done
+
 # Create mock API server
 TEMP_DIR=$(mktemp -d)
 mkdir -p "$TEMP_DIR/app/$VERSION"
@@ -188,9 +218,10 @@ echo ""
 echo -e "${CYAN}╭${HLINE}╮${NC}"
 printf "${CYAN}│${NC}  ${GREEN}%-$((BOX_WIDTH - 2))s${NC}${CYAN}│${NC}\n" "E2E Tests"
 echo -e "${CYAN}├${HLINE}┤${NC}"
-print_row "Device " "http://$DEVICE_IP"
-print_row "Version" "$VERSION"
-print_row "Stable " "$STABLE_VERSION"
+print_row "Device  " "http://$DEVICE_IP"
+print_row "Version " "$VERSION"
+print_row "Stable  " "$STABLE_VERSION"
+print_row "Deployed" "Yes"
 echo -e "${CYAN}╰${HLINE}╯${NC}"
 echo ""
 

ui/e2e/hdmi-sleep-reboot.spec.ts

@@ -2,9 +2,6 @@ import { test, expect } from "@playwright/test";
 
 import { verifyHidAndVideo, reconnectAfterReboot } from "./helpers";
 
-// Time to wait for device to reboot (ms)
-const REBOOT_DELAY = 15000;
-
 // Time to wait for settings to apply (ms)
 const SETTINGS_APPLY_DELAY = 1000;
 
@@ -41,7 +38,7 @@ test.describe("HDMI Sleep Mode and Reboot Tests", () => {
     await yesButton.click();
 
     // Wait for reboot and reconnect
-    await reconnectAfterReboot(page, REBOOT_DELAY);
+    await reconnectAfterReboot(page);
 
     // Verify video, mouse, and keyboard all work
     await verifyHidAndVideo(page);

ui/e2e/helpers.ts

@@ -498,7 +498,7 @@ export async function waitForTerminalReady(page: Page, timeout = 10000): Promise
  */
 export async function reconnectAfterReboot(
   page: Page,
-  waitBeforeRetry = 30000,
+  waitBeforeRetry = 15000,
   maxRetries = 15,
   retryInterval = 3000,
 ): Promise<void> {

ui/e2e/z-ota-update-flow.spec.ts

@@ -54,7 +54,7 @@ test.describe("OTA Update Flow", () => {
 
       try {
         await page.goto("/", { timeout: 10000 });
-        await waitForWebRTCReady(page, 30000);
+        await waitForWebRTCReady(page);
         await waitForTerminalReady(page, 10000);
 
         const restoreCommand = `sed -i 's|"update_api_url": "[^"]*"|"update_api_url": "https://api.jetkvm.com"|' /userdata/kvm_config.json`;
@@ -77,7 +77,7 @@ test.describe("OTA Update Flow", () => {
         configModified = true;
 
         await sendTerminalCommand(page, "reboot", 0);
-        await reconnectAfterReboot(page, 30000);
+        await reconnectAfterReboot(page);
       });
 
       // Phase 2: Downgrade to stable version
@@ -90,7 +90,7 @@ test.describe("OTA Update Flow", () => {
         await expect(updateButton).toBeVisible({ timeout: 20000 });
         await updateButton.click();
 
-        await reconnectAfterReboot(page, 60000);
+        await reconnectAfterReboot(page, 35000);
 
         const afterDowngrade = await getCurrentVersion(page);
         expect(afterDowngrade).toBe(stableVersion);
@@ -106,7 +106,7 @@ test.describe("OTA Update Flow", () => {
         await expect(otaUpdateButton).toBeVisible({ timeout: 20000 });
         await otaUpdateButton.click();
 
-        await reconnectAfterReboot(page, 60000);
+        await reconnectAfterReboot(page, 35000);
 
         const finalVersion = await getCurrentVersion(page);
         expect(finalVersion, "Failed to get version after OTA upgrade").not.toBeNull();

ui/src/routes/devices.$id.settings.general.reboot.tsx

@@ -80,7 +80,13 @@ function ConfirmationBox({
           </div>
         ) : (
           <div className="mt-4 flex gap-x-2">
-            <Button size="SM" theme="light" text={m.general_reboot_yes_button()} onClick={onYes} />
+            <Button
+              size="SM"
+              theme="light"
+              text={m.general_reboot_yes_button()}
+              onClick={onYes}
+              data-testid="reboot-confirm-yes"
+            />
             <Button size="SM" theme="blank" text={m.general_reboot_no_button()} onClick={onNo} />
           </div>
         )}