fixup! message interpreted directly as fixup commit during interactive rebase

[Dsaquel]

AFAIK currently when doing a interactive rebase having a fixup! commit will set by default as pick but it would be nice and straightforward to handle it directly as a fixup one.

[stefanhaller]

No, this wouldn't be a good idea. I often need to preserve fixups for a while (because I want my reviewers to see them), but I still want to be able to do an interactive rebase, e.g. in order to test whether a given commit builds cleanly. It would be very annoying if every interactive rebase would automatically squash fixups.

Squashing fixups is very easy to do using the shift-S command.

[Dsaquel]

No, this wouldn't be a good idea. I often need to preserve fixups for a while (because I want my reviewers to see them), but I still want to be able to do an interactive rebase, e.g. in order to test whether a given commit builds cleanly. It would be very annoying if every interactive rebase would automatically squash fixups.

That sounds reasonable to keep the current status quo.

Squashing fixups is very easy to do using the shift-S command.

My bad, i didn't know about this command, it's really convenient.

Thanks for you quick respond and time!