Skip to content

Bitcode support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdmunro opened this issue Nov 24, 2019 · 5 comments
Closed

Bitcode support #3

jdmunro opened this issue Nov 24, 2019 · 5 comments

Comments

@jdmunro
Copy link
Contributor

jdmunro commented Nov 24, 2019

Is there a reason to disable bitcode support on iOS?

https://github.com/jerson/react-native-fast-openpgp/blob/master/react-native-fast-openpgp.podspec#L21

@jerson
Copy link
Owner

jerson commented Nov 24, 2019

Hi @jdmunro, this openpgp library was made with golang and gomobile, gomobile allow compile a framework for ios but unfortunately it don't support bitcode

@jdmunro
Copy link
Contributor Author

jdmunro commented Nov 25, 2019

@jerson Makes sense, thanks! As I understand it, they now have support for bitcode: golang/mobile@9487ef5

Some other libraries are now supporting it, e.g: https://github.com/DimensionDev/Tessercube-iOS/issues/48 (So it might be possible to support it now)

Bitcode will eventually become mandatory to submit iOS apps to the store.

@jerson
Copy link
Owner

jerson commented Nov 25, 2019

@jdmunro thank you, I did not know, these days I will update the library to support bitcode :D

@jerson
Copy link
Owner

jerson commented Nov 25, 2019

hi @jdmunro i just release v0.5.0 with new binaries with bitcode support, i just tested using this command

otool -arch arm64 -l MyFramework.framework/MyFramework | grep -a4 __LLVM

just update you package.json

npm link: https://www.npmjs.com/package/react-native-fast-openpgp/v/0.5.0

@jerson jerson closed this as completed Nov 25, 2019
@jdmunro
Copy link
Contributor Author

jdmunro commented Nov 25, 2019

Thanks @jerson I can confirm that works 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants