-
-
Notifications
You must be signed in to change notification settings - Fork 20
Bitcode support #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @jdmunro, this openpgp library was made with golang and gomobile, gomobile allow compile a framework for ios but unfortunately it don't support bitcode |
@jerson Makes sense, thanks! As I understand it, they now have support for bitcode: golang/mobile@9487ef5 Some other libraries are now supporting it, e.g: https://github.com/DimensionDev/Tessercube-iOS/issues/48 (So it might be possible to support it now) Bitcode will eventually become mandatory to submit iOS apps to the store. |
@jdmunro thank you, I did not know, these days I will update the library to support bitcode :D |
hi @jdmunro i just release v0.5.0 with new binaries with bitcode support, i just tested using this command otool -arch arm64 -l MyFramework.framework/MyFramework | grep -a4 __LLVM
just update you package.json npm link: https://www.npmjs.com/package/react-native-fast-openpgp/v/0.5.0 |
Thanks @jerson I can confirm that works 🎉 |
Is there a reason to disable bitcode support on iOS?
https://github.com/jerson/react-native-fast-openpgp/blob/master/react-native-fast-openpgp.podspec#L21
The text was updated successfully, but these errors were encountered: