Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Support for plugins / module loading #1

Open
tzvsi opened this issue Apr 21, 2020 · 1 comment
Open

Request: Support for plugins / module loading #1

tzvsi opened this issue Apr 21, 2020 · 1 comment

Comments

@tzvsi
Copy link

tzvsi commented Apr 21, 2020

Thank you for updating MG to ES6 modules. Congrats on the release. I've been following the announcement discussion. I plan on contributing to your fork.

Looking at the API, I'm wondering if or how you'd like to implement MG2 plugin / modules? Do you have a module architecture in mind?

Naturally legacy MG plugins would need to be rewritten, which provides like an opportunity to define a class loader (ie, prior to instantiating LineChart). I have a few ideas, but wanted to open a ticket for discussion.

Side note, I've added support for MG lifecycle events / hooks (as defined in common/hooks.js): add_hook and call_hook methods. This would likely impact modules, which often depend on hooks (ie, line.after_init). Interested in a PR?

@jens-ox
Copy link
Owner

jens-ox commented Apr 21, 2020

Hi! Thanks for checking out the fork. I've not really thought about a plugin architecture so far. A PR would be great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants