Skip to content

Clarifying that PluginServletFilter is not in fact an ExtensionPoint #11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Clarifying that PluginServletFilter is not in fact an ExtensionPoint #11210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions core/src/main/java/hudson/util/PluginServletFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
package hudson.util;

import edu.umd.cs.findbugs.annotations.CheckForNull;
import hudson.ExtensionPoint;
import hudson.security.SecurityRealm;
import io.jenkins.servlet.FilterWrapper;
import io.jenkins.servlet.ServletExceptionWrapper;
Expand All @@ -51,19 +50,16 @@
import org.kohsuke.stapler.CompatibleFilter;

/**
* Servlet {@link Filter} that chains multiple {@link Filter}s, provided by plugins
*
* Servlet {@link Filter} that chains multiple {@link Filter}s, provided by plugins.
* <p>
* While this class by itself is not an extension point, I'm marking this class
* as an extension point so that this class will be more discoverable.
*
* In most cases you should rather use {@link HttpServletFilter}.
* <p>
* {@link SecurityRealm} that wants to contribute {@link Filter}s should first
* check if {@link SecurityRealm#createFilter(FilterConfig)} is more appropriate.
*
* @see SecurityRealm
*/
public final class PluginServletFilter implements CompatibleFilter, ExtensionPoint {
public final class PluginServletFilter implements CompatibleFilter {
private final List<Filter> list = new CopyOnWriteArrayList<>();

private /*almost final*/ FilterConfig config;
Expand Down
Loading