Cannot use accept acceptGitlabMR in a downstream job

[Kimamisa]

Issue

Context

• Gitlab plugin version: 1.5.11
• Gitlab version: 11.8.0-ee
• Jenkins version: 2.150.3
• Job type: Pipeline

I am trying to launch an acceptGitlabMR from my pipeline job. My job is triggered from another job, and then has the Cause (GitLabWebHookCause) wrapped inside an hudson.model.Cause_-UpstreamCause, which prevents the plugin to access the Cause data. Is it supposed to work this way or is this a missing feature ?

I am not sure of this diagnostic, the step is mentionned in the jenkins logs, but there are no error logs at all.

[omehegan]

I would not really expect this to work. The plugin assumes that relevant data structures will be directly accessible to it in the job that was triggered by GitLab. It does not have a provision to pass this data to downstream jobs. I can mark this as a feature request, but I don't have time to work on it.

[Kimamisa]

ok, I'll have a look at it. It seems like the code is already present, and used for the CommitStatusUpdater. I'll try to make it re-usable for the AcceptGitLabMergeRequestStep and AddGitLabMergeRequestCommentStep.

[Kimamisa]

Here's what I've done: #898
It seems to work, but I'm not sure if this implies any side-effects...

[normand1]

This is relative to my interests. Bumping, but unfortunately don't have the relevant knowledge to code review it.