fix: prevent images publication if not latest Weekly or LTS

Author: lemeurherve

.ci/publish.sh

@@ -12,6 +12,7 @@ set -eu -o pipefail
 : "${DOCKERHUB_ORGANISATION:=jenkins}"
 : "${DOCKERHUB_REPO:=jenkins}"
 : "${BAKE_TARGET:=linux}"
+: "${BYPASS_ONLY_LATEST_PUBLICATION:=false}"
 
 export JENKINS_REPO="${DOCKERHUB_ORGANISATION}/${DOCKERHUB_REPO}"
 
@@ -76,6 +77,16 @@ else
     LATEST_LTS="false"
 fi
 
+if [[ "${LATEST_WEEKLY}" == "false" && "${LATEST_LTS}" == "false" ]]; then
+    if [[ "${BYPASS_ONLY_LATEST_PUBLICATION}" == "false" ]]; then
+        echo "ERROR: ${JENKINS_VERSION} is neither the lastest Weekly nor the latest LTS version, not publishing any image"
+        exit 1
+    else
+        echo "WARNING: ${JENKINS_VERSION} is neither the lastest Weekly nor the latest LTS version"
+        echo 'As BYPASS_ONLY_LATEST_PUBLICATION has been set to "true", still proceeding to its publication'
+    fi
+fi
+
 build_opts=("--pull")
 metadata_suffix="publish"
 if test "${dry_run}" == "true"; then
@@ -100,6 +111,9 @@ Using the following settings:
 * COMMIT_SHA: ${COMMIT_SHA}
 * LATEST_WEEKLY: ${LATEST_WEEKLY}
 * LATEST_LTS: ${LATEST_LTS}
+* latest_weekly_version: ${latest_weekly_version}
+* latest_lts_version: ${latest_lts_version}
+* BYPASS_ONLY_LATEST_PUBLICATION: ${BYPASS_ONLY_LATEST_PUBLICATION}
 * BUILD_METADATA_PATH: ${BUILD_METADATA_PATH}
 * BAKE_TARGET: ${BAKE_TARGET}
 * BAKE OPTIONS:

make.ps1

@@ -42,21 +42,6 @@ $env:DOCKERHUB_REPO = "$Repository"
 $env:JENKINS_VERSION = "$JenkinsVersion"
 $env:COMMIT_SHA = git rev-parse HEAD
 
-# Add 'lts-' prefix to LTS tags not including Jenkins version
-# Compared to weekly releases, LTS releases include an additional build number in their version
-# Note: the ':' separator is included as trying to set an environment variable to empty on Windows unset it.
-$env:SEPARATOR_LTS_PREFIX = ':'
-$releaseLine = 'war'
-if ($JenkinsVersion.Split('.').Count -eq 3) {
-    $env:SEPARATOR_LTS_PREFIX = ':lts-'
-    $releaseLine = 'war-stable'
-}
-
-# If there is no WAR_URL set, using get.jenkins.io URL depending on the release line
-if([String]::IsNullOrWhiteSpace($env:WAR_URL)) {
-    $env:WAR_URL = 'https://get.jenkins.io/{0}/{1}/jenkins.war' -f $releaseLine, $env:JENKINS_VERSION
-}
-
 # Check for required commands
 Function Test-CommandExists {
     Param (
@@ -121,6 +106,52 @@ function Test-Image {
 
     return $failed
 }
+function Test-IsLatestJenkinsRelease {
+    param (
+        [String] $Version
+    )
+
+    Write-Host "= PREPARE: Checking if $env:JENKINS_VERSION is latest Weekly or LTS..."
+
+    $metadataUrl = "https://repo.jenkins-ci.org/releases/org/jenkins-ci/main/jenkins-war/maven-metadata.xml"
+    try {
+        [xml]$metadata = Invoke-WebRequest $metadataUrl -UseBasicParsing
+    }
+    catch {
+        Write-Error "Failed to retrieve Jenkins versions from Artifactory"
+        exit 1
+    }
+    $allVersions = $metadata.metadata.versioning.versions.version
+
+    # Weekly
+    $weeklyVersions = $allVersions |
+        Where-Object { $_ -match '^\d+\.\d+$' } |
+        ForEach-Object { [version]$_ } |
+        Sort-Object
+
+    # LTS
+    $ltsVersions = $allVersions |
+        Where-Object { $_ -match '^\d+\.\d+\.\d+$' } |
+        ForEach-Object { [version]$_ } |
+        Sort-Object
+
+    $latestWeeklyVersion = $weeklyVersions[-1]
+    Write-Host "latest Weekly version: $latestWeeklyVersion"
+    $latestLTSVersion    = $ltsVersions[-1]
+    Write-Host "latest LTS version: $latestLTSVersion"
+
+    $latest = $false
+    if ($Version -eq $latestWeeklyVersion) {
+        $latest = $true
+    }
+    if ($Version -eq $latestLTSVersion) {
+        $latest = $true
+    }
+    if (!$latest) {
+        Write-Host "WARNING: $JenkinsVersion is neither the lastest Weekly nor the latest LTS version"
+    }
+    return $latest
+}
 
 function Initialize-DockerComposeFile {
     param (
@@ -166,6 +197,24 @@ Test-CommandExists 'yq'
 # Sanity check
 yq --version
 
+# Add 'lts-' prefix to LTS tags not including Jenkins version
+# Compared to weekly releases, LTS releases include an additional build number in their version
+$releaseLine = 'war'
+# Determine if the current JENKINS_VERSION corresponds to the latest Weekly or LTS version from Artifactory 
+$isJenkinsVersionLatest = Test-IsLatestJenkinsRelease -Version $JenkinsVersion
+
+if ($JenkinsVersion.Split('.').Count -eq 3) {
+    $releaseLine = 'war-stable'
+    $env:LATEST_LTS = $isJenkinsVersionLatest
+} else {
+    $env:LATEST_WEEKLY = $isJenkinsVersionLatest
+}
+
+# If there is no WAR_URL set, using get.jenkins.io URL depending on the release line
+if([String]::IsNullOrWhiteSpace($env:WAR_URL)) {
+    $env:WAR_URL = 'https://get.jenkins.io/{0}/{1}/jenkins.war' -f $releaseLine, $JenkinsVersion
+}
+
 $dockerComposeFile = 'build-windows_{0}.yaml' -f $ImageType
 $baseDockerCmd = 'docker-compose --file={0}' -f $dockerComposeFile
 $baseDockerBuildCmd = '{0} build --parallel --pull' -f $baseDockerCmd
@@ -239,6 +288,13 @@ if ($target -eq 'test') {
 
 if ($target -eq 'publish') {
     Write-Host '= PUBLISH: push all images and tags'
+
+    # Prevent publication if JENKINS_VERSION is not the latest Weekly or LTS version
+    if (!$isJenkinsVersionLatest -and !$env:BYPASS_ONLY_LATEST_PUBLICATION) {
+        Write-Host "ERROR: $JenkinsVersion is neither the lastest Weekly nor the latest LTS version"
+        exit 1
+    }
+
     switch($DryRun) {
         $true { Write-Host "(dry-run) $baseDockerCmd push" }
         $false { Invoke-Expression "$baseDockerCmd push" }