Merge pull request #77 from slickoner/bugfix/fix-pipeline-extra-vars-boolean

Fix Boolean support for extra vars in pipeline and add minimal pipeline test

Author: jonesbusy

src/main/java/org/jenkinsci/plugins/ansible/workflow/AnsiblePlaybookStep.java

@@ -391,6 +391,10 @@ else if (o instanceof String) {
                     var.setSecretValue(Secret.fromString((String)o));
                     var.setHidden(true);
                 }
+                else if (o instanceof Boolean) {
+                    var.setSecretValue(Secret.fromString(o.toString()));
+                    var.setHidden(true);
+                }
                 else if (o instanceof Secret) {
                     var.setSecretValue((Secret)o);
                     var.setHidden(true);

src/test/java/org/jenkinsci/plugins/ansible/PipelineTest.java

@@ -65,4 +65,16 @@ public void testExtraVarsMap() throws Exception {
         ));
     }
 
+    @Test
+    public void testExtraVarsBoolean() throws Exception {
+        String pipeline = IOUtils.toString(PipelineTest.class.getResourceAsStream("/pipelines/extraVarsBoolean.groovy"), StandardCharsets.UTF_8);
+        WorkflowJob workflowJob = jenkins.createProject(WorkflowJob.class);
+        workflowJob.setDefinition(new CpsFlowDefinition(pipeline, true));
+        WorkflowRun run1 = workflowJob.scheduleBuild2(0).waitForStart();
+        jenkins.waitForCompletion(run1);
+        assertThat(run1.getLog(), allOf(
+                containsString("ansible-playbook playbook.yml -e ******** -e ********")
+        ));
+    }
+
 }

src/test/resources/pipelines/extraVarsBoolean.groovy

@@ -0,0 +1,27 @@
+pipeline {
+    agent {
+        label('test-agent')
+    }
+    stages {
+        stage('Create playbook') {
+            steps {
+                writeFile(encoding: 'UTF-8', file: 'playbook.yml', text: '''- hosts: localhost
+  connection: local
+  gather_facts: no
+  tasks:
+    - debug: msg=test
+                ''')
+            }
+        }
+        stage('Ansible playbook') {
+            steps {
+                warnError(message: 'ansible command not found?') {
+                    ansiblePlaybook(
+                            playbook: 'playbook.yml',
+                            extraVars: [foo1: true, foo2: false],
+                    )
+                }
+            }
+        }
+    }
+}