Use url.JoinPath to build fullURL and handle errors

rene-post · rene-post · commit 53f12d552817 · 2025-06-13T10:58:06.000+02:00
diff --git a/pkg/openapi2mcp/register.go b/pkg/openapi2mcp/register.go
@@ -1121,7 +1121,10 @@ func RegisterOpenAPITools(server *mcpserver.MCPServer, ops []OpenAPIOperation, d
 			}
 			// Pick a random baseURL for each call using the global rand
 			baseURL := baseURLs[rand.Intn(len(baseURLs))]
-			fullURL := baseURL + path
+			fullURL, err := url.JoinPath(baseURL, path)
+			if err != nil {
+				return nil, err
+			}
 			if len(query) > 0 {
 				fullURL += "?" + query.Encode()
 			}

Original file line number	Diff line number	Diff line change
`@@ -1121,7 +1121,10 @@ func RegisterOpenAPITools(server *mcpserver.MCPServer, ops []OpenAPIOperation, d`
`1121`	`1121`	`}`
`1122`	`1122`	`// Pick a random baseURL for each call using the global rand`
`1123`	`1123`	`baseURL := baseURLs[rand.Intn(len(baseURLs))]`
`1124`		`- fullURL := baseURL + path`
	`1124`	`+ fullURL, err := url.JoinPath(baseURL, path)`
	`1125`	`+ if err != nil {`
	`1126`	`+ return nil, err`
	`1127`	`+ }`
`1125`	`1128`	`if len(query) > 0 {`
`1126`	`1129`	`fullURL += "?" + query.Encode()`
`1127`	`1130`	`}`