-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inputs get messed up when a line overflows #7
Comments
I am currently not able to reproduce this (tried bash, fish, zsh)... |
Seems to happen if the window width is narrow and some of the content (e.g "help") overflows to a new line. |
oh I probably never accounted for the help overflowing |
not quite sure how we could deal with this. i have a similar obstacles implementing text input. |
we have to make A couple of things will help with this:
|
I guess the logic should be something like: self.height = output.lines().count() + output.lines().map(|l| measure_text_width(l).len() / WIDTH).sum() |
i see, something around iterating the lines and add 1 more for each that is longer than the terminal width |
It seems certainly related to the help texts overflowing the terminal width but it seems, even adding lines by a more elaborate height calculation does not seem to help. Needs further investigation...
|
did not find a fix yet, calling |
this seems to affect all inputs with lines which might overflow, hence renaming |
The text was updated successfully, but these errors were encountered: