Skip to content

Commit 2a46acd

Browse files
Tests for OrgDate Parsing: Be liberal in what you tolerate on the receiving end
1 parent e1f64eb commit 2a46acd

File tree

1 file changed

+23
-5
lines changed

1 file changed

+23
-5
lines changed

tests/test_liborgdate_parsing.py

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,32 @@ def test_get_orgdate_parsing_inactive(self):
9090
result = get_orgdate(self.textinactive)
9191
self.assertNotEqual(result, None)
9292
self.assertTrue(isinstance(result, OrgDate))
93-
self.assertTrue(isinstance(get_orgdate(u"[2011-08-30 Tue]"), OrgDate))
94-
self.assertEqual(get_orgdate(u"[2011-08-30 Tue]").year, 2011)
95-
self.assertEqual(get_orgdate(u"[2011-08-30 Tue]").month, 8)
96-
self.assertEqual(get_orgdate(u"[2011-08-30 Tue]").day, 30)
97-
self.assertFalse(get_orgdate(u"[2011-08-30 Tue]").active)
93+
94+
text = u"[2011-08-30 Tue]"
95+
expected_result = OrgDate(False, 2011, 8, 30)
96+
result = get_orgdate(text)
97+
self.assertTrue(isinstance(result, OrgDate))
98+
self.assertEqual(result, expected_result)
99+
self.assertEqual(result.active == False, expected_result.active == False)
98100

99101
datestr = u"This date [2011-08-30 Tue] is embedded"
100102
self.assertTrue(isinstance(get_orgdate(datestr), OrgDate))
101103

104+
text = u"[2011-08-30]"
105+
expected_result = OrgDate(False, 2011, 8, 30)
106+
result = get_orgdate(text)
107+
self.assertTrue(isinstance(result, OrgDate))
108+
self.assertEqual(result, expected_result)
109+
self.assertEqual(result.active == False, expected_result.active == False)
110+
111+
112+
text = u"[2011-08-30 Dienstag]"
113+
expected_result = OrgDate(False, 2011, 8, 30)
114+
result = get_orgdate(text)
115+
self.assertTrue(isinstance(result, OrgDate))
116+
self.assertEqual(result, expected_result)
117+
self.assertEqual(result.active == False, expected_result.active == False)
118+
102119
def test_get_orgdatetime_parsing_passive(self):
103120
u"""
104121
get_orgdate should recognize all orgdatetimes in a given text
@@ -169,6 +186,7 @@ def test_get_orgdate_parsing_with_list_of_texts(self):
169186
self.assertEqual(result.minute, 10)
170187

171188
def test_get_orgdate_parsing_with_invalid_input(self):
189+
self.assertEquals(get_orgdate(u""), None)
172190
self.assertEquals(get_orgdate(u"NONSENSE"), None)
173191
self.assertEquals(get_orgdate(u"No D<2011- Date 08-29 Mon>"), None)
174192
self.assertEquals(get_orgdate(u"2011-08-r9 Mon]"), None)

0 commit comments

Comments
 (0)