Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed command does not abort hooks #13

Open
jaxvanyang opened this issue Jan 17, 2024 · 2 comments
Open

Failed command does not abort hooks #13

jaxvanyang opened this issue Jan 17, 2024 · 2 comments
Assignees
@jaxvanyang
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jaxvanyang
Copy link
Owner

For example:

- pre_backup:
  - |
    false
    echo 'should stop before'

This will always echo. A workaround is adding set -e at the beginning of script.
@jaxvanyang jaxvanyang added the bug Something isn't working label Jan 17, 2024
@jaxvanyang jaxvanyang self-assigned this Jan 17, 2024
@jaxvanyang jaxvanyang pinned this issue Jan 19, 2024
@jaxvanyang jaxvanyang moved this to Backlog in dotbackup v1.0.0 Jan 19, 2024
@jaxvanyang jaxvanyang removed the status in dotbackup v1.0.0 Jan 24, 2024
@jaxvanyang
Copy link
Owner Author

Won't fix at this moment.

@jaxvanyang jaxvanyang closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
@jaxvanyang jaxvanyang added the wontfix This will not be worked on label Mar 12, 2024
@jaxvanyang
Copy link
Owner Author

Prepend set -ex may be a good idea.

@jaxvanyang jaxvanyang reopened this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaxvanyang jaxvanyang

Labels
bug Something isn't working wontfix This will not be worked on
Projects
No open projects
dotbackup v1.0.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaxvanyang