Problem with install

[KrisSee]

When following the docs and running a pip install, I was getting errors which I traced back to AGB_data.py not being installed for classification calculations. I cloned and installed as a dev environment and that runs fine. I assume that wasn't intended.

[jatkinson1000]

Hi @KrisSee thanks for opening an issue.
Can you be a bit more specific with how to reproduce this error?

I ran:

python3 -m venv venv
source venv/bin/activate

pip install archeryutils

all OK.

I can then boot into a Python repl (or run as a script)

import archeryutils as au
my720target = au.Target("10_zone", 122, 70.0)
...

My suspicion is that you are referring to the updated version of the classification functions that are in main on GitHub, but not the most recent PyPI release.
These underwent a pretty major overhaul as part of #113 which resulted in an API change for classifications.

I intended to release a version 2.0 to PyPI with these in, but had hoped that #103 might go in before that. However, it seems to have stagnated.

My suggestions, depending on your use case, would be:

• Use the PyPI version with the old API based on the documentation at https://github.com/jatkinson1000/archeryutils/releases/tag/v1.1.1 accepting that this will change with the release of v2.0.0
  See the "stable" docs here: https://archeryutils.readthedocs.io/en/stable/index.html rather than using the "latest".
• Use the development version for now and watch for the v2.0.0 (e.g. by starring the repo and 'watching' for releases).
  Either with a local clone and install, or in dependencies as pip install git+https://github.com/jatkinson1000/archeryutils.git

I have been busy recently, but will look to create a v2.0.0 release as soon as I get some time.

[KrisSee]

Thanks for the quick response, I'm not really a python person so it took a while and I wasn't sure why it was happening. I setup the venv and ran pip install archeryutils

Tried some code which failed but had been testing a while assuming it was my code, I got to the point of running this:
python - <<'PY'
from archeryutils.classifications.AGB_data import AGB_bowstyles, AGB_genders, AGB_ages
from archeryutils.classifications import agb_outdoor_classifications as out
from archeryutils import load_rounds
 
r = load_rounds.AGB_outdoor_imperial.hereford
scores = out.agb_outdoor_classification_scores(
r,
AGB_bowstyles.RECURVE,
AGB_genders.MALE,
AGB_ages.AGE_50_PLUS,
)
print(scores.tolist())
PY
 
This errored with:
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'archeryutils.classifications.AGB_data'

When I checked AGB_data.py was not in the classifications directory installed and assumed it was problem with the install. It sounds like this is what you are describing I've now followed the dev install in the docs, cloning and running the pip install -e .[dev], and looks like I'm ok now. Just need to finish the code to get the tables in the format I needed, it is a one off create dataset until the classifications change. I'll keep an eye on what is happening, so I'm ready for when AGB move the goalposts next time :-). So we can close this.

[jatkinson1000]

Hey @KrisSee just to follow up on this I have now made a new release for v2.0.0 and uploaded this to PyPI.

So you should now get the very latest when you pip install archeryutils.

I hope the code is useful, and do let me know if there are any other things that you would like to see in there.
If you are publishing online or elsewhere anything you generated with this code I'd really appreciate it if you could add some accreditation to it. 🙏
I'm also always happy to see/hear about anything the code has facilitated for the archery community.

If you are generating tables note that there are functionalities to do this in the code (you don't have to do every value one-by-one), and you can probably get much of the data you want from the online counterpart to this code at https://archerycalculator.co.uk/

[KrisSee]

@jatkinson1000 Thanks I'll have a look but I have already done the generate now, and I am working it in the app, slowly when I get a chance. I will definitely add a credit to you, if I ever finish it. My main reason for using the code was I didn't want to be seen to be ripping the tables from other sites, even if they are public domain. So nothing clever with using your code, I just needed to get a json version of classification tables and rounds. I'm new to archery (less than 6 months, but that is longer than my app coding experience), so my use case, may be useless to others and it wasn't going to monetised in any way.