Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using GitHub releases so that pinning versions is easier #123

Closed
JohnRoesler opened this issue Nov 6, 2019 · 4 comments
Closed

Comments

@JohnRoesler
Copy link
Contributor

Right now, in order to pin to a specific version of gocron - I have to know the commit and commit date/time I want to point on master.

If we use github releases - then pulling with go mod allows to set the version pin. For example:

- 	github.com/jasonlvhit/gocron v0.0.0-20191103124442-96e810119cd2
+ 	github.com/jasonlvhit/gocron v1.0.1
@JohnRoesler
Copy link
Contributor Author

@preslavrachev @Streppel

@Streppel
Copy link
Collaborator

Streppel commented Nov 6, 2019

Completely agree. I'll be creating a version 0.5 as a pre-release as we still need to merge a really important PR that adds production safety (but currently has some code conflicts) and work on some code and tests to fix problems like #19 and #50 in order to consider this package to be production ready. What do you think?

@JohnRoesler
Copy link
Contributor Author

Yes i think that makes sense. A big thing I'd like to see is a way to have errors passed back out (channel maybe) so that I could decide how to handle different errors that may occur during my cron's run.

@Streppel
Copy link
Collaborator

And from now on we have our pre-release version 0.1!

https://github.com/jasonlvhit/gocron/releases/tag/0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants