-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs I’ve found #75
Comments
Thanks so much for the report and apologies for not responding sooner! (I missed it!) Just to confirm- Are all of these on the latest version? Yes, totally understand about a timeline interface- the clock in your top right is only so helpful. I’ll check out these issues and think about the right way to build the timeline. appreciate you trying it out! And if you know any swift devs or people will to figure it out, feel free to send them this way! I have limited bandwidth, and sometimes use that time to explore companion projects. (Like once you have this context, what can you do with it?) |
I believe #90 will fix the timeline missing frame bug you mentioned |
I've never seen this before:
I'd love to see if that's still happening after #90 is merged |
(#90 is merged) |
@jasonjmcghee I'm realizing I actually introduced a bug with #90 . The issue is Search is still based off of indexes with the frames table, while the timeline now works on indexes within the chunksFramesView. Therefore, when a search thumbnail is clicked the frames index is passed, but the timeline treats it as a chunksFramesIndex. One possible solution is to convert the Search functionality to also use the chunksFramesView. Only downsides I can think of is now frames with relevant text but without a chunk will no longer appear (probably a fix but could be considered bad) and potentially performance (shouldn't be an issue). The other solution is to just convert the frames index to a chunksFramesIndex before it is passed to showTimelineView(). |
@cparish312 - sounds like a perfectly good fix. if there's no chunk 🤷 probably not worth showing |
Hello,
First I must say thank you for this project, as it could become a real replacement for RewindAI; which I couldn’t morally setup as it wasn’t open source (my Mac has my entire life on it so I’m really careful).
I’m here to report several bugs I’ve encountered:
I think that’s all for the bugs.
There’s just one single feature that would be enough to make the app really work (even if so many things can be added to it, of course), this is the presence of the timeline in the timeline. Not knowing when a picture is dated is really unpractical for fast search.
All in all, I really hope this project has a bright future, as I think that having open source AI is a must have.
Cheers.
The text was updated successfully, but these errors were encountered: