Skip to content

Commit a5706e8

Browse files
committed
test: Always use strictEqual to ensure null and undefined values are asserted correctly
1 parent b8e1e6a commit a5706e8

File tree

1 file changed

+48
-48
lines changed

1 file changed

+48
-48
lines changed

test.js

Lines changed: 48 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -11,42 +11,42 @@ var obj = {
1111
}
1212
}
1313

14-
assert.equal(jsonpointer.get(obj, '/a'), 1)
15-
assert.equal(jsonpointer.get(obj, '/b/c'), 2)
16-
assert.equal(jsonpointer.get(obj, '/d/e/0/a'), 3)
17-
assert.equal(jsonpointer.get(obj, '/d/e/1/b'), 4)
18-
assert.equal(jsonpointer.get(obj, '/d/e/2/c'), 5)
14+
assert.strictEqual(jsonpointer.get(obj, '/a'), 1)
15+
assert.strictEqual(jsonpointer.get(obj, '/b/c'), 2)
16+
assert.strictEqual(jsonpointer.get(obj, '/d/e/0/a'), 3)
17+
assert.strictEqual(jsonpointer.get(obj, '/d/e/1/b'), 4)
18+
assert.strictEqual(jsonpointer.get(obj, '/d/e/2/c'), 5)
1919

2020
// set returns old value
21-
assert.equal(jsonpointer.set(obj, '/a', 2), 1)
22-
assert.equal(jsonpointer.set(obj, '/b/c', 3), 2)
23-
assert.equal(jsonpointer.set(obj, '/d/e/0/a', 4), 3)
24-
assert.equal(jsonpointer.set(obj, '/d/e/1/b', 5), 4)
25-
assert.equal(jsonpointer.set(obj, '/d/e/2/c', 6), 5)
21+
assert.strictEqual(jsonpointer.set(obj, '/a', 2), 1)
22+
assert.strictEqual(jsonpointer.set(obj, '/b/c', 3), 2)
23+
assert.strictEqual(jsonpointer.set(obj, '/d/e/0/a', 4), 3)
24+
assert.strictEqual(jsonpointer.set(obj, '/d/e/1/b', 5), 4)
25+
assert.strictEqual(jsonpointer.set(obj, '/d/e/2/c', 6), 5)
2626

2727
// set nested properties
28-
assert.equal(jsonpointer.set(obj, '/f/g/h/i', 6), undefined)
29-
assert.equal(jsonpointer.get(obj, '/f/g/h/i'), 6)
28+
assert.strictEqual(jsonpointer.set(obj, '/f/g/h/i', 6), undefined)
29+
assert.strictEqual(jsonpointer.get(obj, '/f/g/h/i'), 6)
3030

3131
// set an array
32-
assert.equal(jsonpointer.set(obj, '/f/g/h/foo/-', 'test'), undefined)
32+
assert.strictEqual(jsonpointer.set(obj, '/f/g/h/foo/-', 'test'), undefined)
3333
var arr = jsonpointer.get(obj, '/f/g/h/foo')
3434
assert(Array.isArray(arr), 'set /- creates an array.')
35-
assert.equal(arr[0], 'test')
35+
assert.strictEqual(arr[0], 'test')
3636

37-
assert.equal(jsonpointer.get(obj, '/a'), 2)
38-
assert.equal(jsonpointer.get(obj, '/b/c'), 3)
39-
assert.equal(jsonpointer.get(obj, '/d/e/0/a'), 4)
40-
assert.equal(jsonpointer.get(obj, '/d/e/1/b'), 5)
41-
assert.equal(jsonpointer.get(obj, '/d/e/2/c'), 6)
37+
assert.strictEqual(jsonpointer.get(obj, '/a'), 2)
38+
assert.strictEqual(jsonpointer.get(obj, '/b/c'), 3)
39+
assert.strictEqual(jsonpointer.get(obj, '/d/e/0/a'), 4)
40+
assert.strictEqual(jsonpointer.get(obj, '/d/e/1/b'), 5)
41+
assert.strictEqual(jsonpointer.get(obj, '/d/e/2/c'), 6)
4242

4343
// can set `null` as a value
44-
assert.equal(jsonpointer.set(obj, '/f/g/h/foo/0', null), 'test')
44+
assert.strictEqual(jsonpointer.set(obj, '/f/g/h/foo/0', null), 'test')
4545
assert.strictEqual(jsonpointer.get(obj, '/f/g/h/foo/0'), null)
46-
assert.equal(jsonpointer.set(obj, '/b/c', null), 3)
46+
assert.strictEqual(jsonpointer.set(obj, '/b/c', null), 3)
4747
assert.strictEqual(jsonpointer.get(obj, '/b/c'), null)
4848

49-
assert.equal(jsonpointer.get(obj, ''), obj)
49+
assert.strictEqual(jsonpointer.get(obj, ''), obj)
5050
assert.throws(function () { jsonpointer.get(obj, 'a') }, validateError)
5151
assert.throws(function () { jsonpointer.get(obj, 'a/') }, validateError)
5252

@@ -76,19 +76,19 @@ var complexKeys = {
7676
'01': 4
7777
}
7878

79-
assert.equal(jsonpointer.get(complexKeys, '/a~1b/c'), 1)
80-
assert.equal(jsonpointer.get(complexKeys, '/d/e~1f'), 2)
81-
assert.equal(jsonpointer.get(complexKeys, '/~01'), 3)
82-
assert.equal(jsonpointer.get(complexKeys, '/01'), 4)
83-
assert.equal(jsonpointer.get(complexKeys, '/a/b/c'), null)
84-
assert.equal(jsonpointer.get(complexKeys, '/~1'), null)
79+
assert.strictEqual(jsonpointer.get(complexKeys, '/a~1b/c'), 1)
80+
assert.strictEqual(jsonpointer.get(complexKeys, '/d/e~1f'), 2)
81+
assert.strictEqual(jsonpointer.get(complexKeys, '/~01'), 3)
82+
assert.strictEqual(jsonpointer.get(complexKeys, '/01'), 4)
83+
assert.strictEqual(jsonpointer.get(complexKeys, '/a/b/c'), undefined)
84+
assert.strictEqual(jsonpointer.get(complexKeys, '/~1'), undefined)
8585

8686
// draft-ietf-appsawg-json-pointer-08 has special array rules
8787
var ary = ['zero', 'one', 'two']
88-
assert.equal(jsonpointer.get(ary, '/01'), null)
88+
assert.strictEqual(jsonpointer.get(ary, '/01'), undefined)
8989

90-
assert.equal(jsonpointer.set(ary, '/-', 'three'), null)
91-
assert.equal(ary[3], 'three')
90+
assert.strictEqual(jsonpointer.set(ary, '/-', 'three'), undefined)
91+
assert.strictEqual(ary[3], 'three')
9292

9393
// Examples from the draft:
9494
var example = {
@@ -104,28 +104,28 @@ var example = {
104104
'm~n': 8
105105
}
106106

107-
assert.equal(jsonpointer.get(example, ''), example)
107+
assert.strictEqual(jsonpointer.get(example, ''), example)
108108
var ans = jsonpointer.get(example, '/foo')
109-
assert.equal(ans.length, 2)
110-
assert.equal(ans[0], 'bar')
111-
assert.equal(ans[1], 'baz')
112-
assert.equal(jsonpointer.get(example, '/foo/0'), 'bar')
113-
assert.equal(jsonpointer.get(example, '/'), 0)
114-
assert.equal(jsonpointer.get(example, '/a~1b'), 1)
115-
assert.equal(jsonpointer.get(example, '/c%d'), 2)
116-
assert.equal(jsonpointer.get(example, '/e^f'), 3)
117-
assert.equal(jsonpointer.get(example, '/g|h'), 4)
118-
assert.equal(jsonpointer.get(example, '/i\\j'), 5)
119-
assert.equal(jsonpointer.get(example, '/k\'l'), 6)
120-
assert.equal(jsonpointer.get(example, '/ '), 7)
121-
assert.equal(jsonpointer.get(example, '/m~0n'), 8)
109+
assert.strictEqual(ans.length, 2)
110+
assert.strictEqual(ans[0], 'bar')
111+
assert.strictEqual(ans[1], 'baz')
112+
assert.strictEqual(jsonpointer.get(example, '/foo/0'), 'bar')
113+
assert.strictEqual(jsonpointer.get(example, '/'), 0)
114+
assert.strictEqual(jsonpointer.get(example, '/a~1b'), 1)
115+
assert.strictEqual(jsonpointer.get(example, '/c%d'), 2)
116+
assert.strictEqual(jsonpointer.get(example, '/e^f'), 3)
117+
assert.strictEqual(jsonpointer.get(example, '/g|h'), 4)
118+
assert.strictEqual(jsonpointer.get(example, '/i\\j'), 5)
119+
assert.strictEqual(jsonpointer.get(example, '/k\'l'), 6)
120+
assert.strictEqual(jsonpointer.get(example, '/ '), 7)
121+
assert.strictEqual(jsonpointer.get(example, '/m~0n'), 8)
122122

123123
// jsonpointer.compile(path)
124124
var a = { foo: 'bar' }
125125
var pointer = jsonpointer.compile('/foo')
126-
assert.equal(pointer.get(a), 'bar')
127-
assert.equal(pointer.set(a, 'test'), 'bar')
128-
assert.equal(pointer.get(a), 'test')
126+
assert.strictEqual(pointer.get(a), 'bar')
127+
assert.strictEqual(pointer.set(a, 'test'), 'bar')
128+
assert.strictEqual(pointer.get(a), 'test')
129129
assert.deepEqual(a, { foo: 'test' })
130130

131131
var b = {}

0 commit comments

Comments
 (0)