The "all" operation will fail with "first argument to all must be a valid array" (#42)

Added tests for different "all in" cases.

Co-authored-by: Rickard Katz <[email protected]>
Co-authored-by: Sam Jesso <[email protected]>

Author: 3 people

src/main/java/io/github/jamsesso/jsonlogic/evaluator/expressions/AllExpression.java

@@ -28,6 +28,10 @@ public Object evaluate(JsonLogicEvaluator evaluator, JsonLogicArray arguments, O
 
     Object maybeArray = evaluator.evaluate(arguments.get(0), data);
 
+    if (maybeArray == null) {
+      return false;
+    }
+
     if (!ArrayLike.isEligible(maybeArray)) {
       throw new JsonLogicEvaluationException("first argument to all must be a valid array");
     }

src/test/resources/fixtures.json

@@ -3711,5 +3711,119 @@
       "items": []
     },
     false
+  ],
+  [
+    {
+      "all": [
+        {
+          "var": ""
+        },
+        {
+          "in": [
+            {
+              "var": ""
+            },
+            ["item1","item2","item3"]
+          ]
+        }
+      ]
+    },
+    [],
+    false
+  ],
+  [
+    {
+      "all": [
+        {
+          "var": ""
+        },
+        {
+          "in": [
+            {
+              "var": ""
+            },
+            ["item1","item2","item3"]
+          ]
+        }
+      ]
+    },
+    ["item1"],
+    true
+  ],
+  [
+    {
+      "all": [
+        {
+          "var": ""
+        },
+        {
+          "in": [
+            {
+              "var": ""
+            },
+            ["item1","item2","item3"]
+          ]
+        }
+      ]
+    },
+    ["item4"],
+    false
+  ],
+  [
+    {
+      "all": [
+        {
+          "var": "item"
+        },
+        {
+          "in": [
+            {
+              "var": ""
+            },
+            ["item1","item2","item3"]
+          ]
+        }
+      ]
+    },
+    {},
+    false
+  ],
+  [
+    {
+      "all": [
+        {
+          "var": "item"
+        },
+        {
+          "in": [
+            {
+              "var": ""
+            },
+            ["item1","item2","item3"]
+          ]
+        }
+      ]
+    },
+    { "item": ["item1"] },
+    true
+  ],
+  [
+    {
+      "all": [
+        {
+          "var": "item"
+        },
+        {
+          "in": [
+            {
+              "var": ""
+            },
+            ["item1","item2","item3"]
+          ]
+        }
+      ]
+    },
+    { "item": ["item4"] },
+    false
   ]
 ]