feat(query/apiv3): implement GetDependencies gRPC handler #7805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @albertteoh, just checking in on this PR. I've updated the branch and everything passes locally (make fmt, make lint). Would you have time to review when you get a chance? Happy to address any feedback. |
Implements jaegertracing/jaeger-idl#45 Fixes jaegertracing#7595 Signed-off-by: Sapthagiri777 <[email protected]>
Sapthagiri777
force-pushed
the
feature/7595-api-v3-dependencies
branch
from
b8f5031 to
cd5fe98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements jaegertracing/jaeger-idl#45
Fixes #7595
Which problem is this PR solving?
Implements API v3
GetDependenciesRPC defined in jaegertracing/jaeger-idl#45 to enable service dependency graph queries. Completes #7595Description of the changes
GetDependenciesgRPC handler tocmd/jaeger/internal/extension/jaegerquery/internal/apiv3/grpc_handler.gotraceQueryManager.GetDependencies()storage backendmodel.Dependencies→api_v3.DependenciesResponse(parent/child/call_count)api_v3.GetDependenciesRequest/Responsemake fmt, passesmake lintHow was this change tested?
make fmt✅make lint✅make testin CIGetOperationshandlerChecklist
jaeger:make lint✅