Avoid opening pages during healthy doctor checks

Author: dyss1992

src/doctor.test.ts

@@ -49,7 +49,7 @@ describe('doctor report rendering', () => {
   beforeEach(() => {
     vi.clearAllMocks();
     mockFindShadowedUserAdapters.mockReturnValue([]);
-    // Doctor always runs live connectivity. Tests that want connect to fail override.
+    // Doctor falls back to a live browser command only when status is not ready.
     mockConnect.mockResolvedValue({
       evaluate: vi.fn().mockResolvedValue(2),
       closeWindow: vi.fn().mockResolvedValue(undefined),
@@ -181,7 +181,9 @@ describe('doctor report rendering', () => {
 
   it('reports daemon not running when connectivity fails and daemon stays stopped', async () => {
     mockConnect.mockRejectedValueOnce(new Error('Could not start daemon'));
-    mockGetDaemonHealth.mockResolvedValueOnce({ state: 'stopped', status: null });
+    mockGetDaemonHealth
+      .mockResolvedValueOnce({ state: 'stopped', status: null })
+      .mockResolvedValueOnce({ state: 'stopped', status: null });
 
     const report = await runBrowserDoctor();
 
@@ -194,7 +196,9 @@ describe('doctor report rendering', () => {
   });
 
   it('reports flapping when live check succeeds but final status shows extension disconnected', async () => {
-    mockGetDaemonHealth.mockResolvedValueOnce({ state: 'no-extension', status: { extensionConnected: false } });
+    mockGetDaemonHealth
+      .mockResolvedValueOnce({ state: 'no-extension', status: { extensionConnected: false } })
+      .mockResolvedValueOnce({ state: 'no-extension', status: { extensionConnected: false } });
 
     const report = await runBrowserDoctor();
 
@@ -207,7 +211,9 @@ describe('doctor report rendering', () => {
   });
 
   it('reports daemon flapping when live check succeeds but daemon disappears afterward', async () => {
-    mockGetDaemonHealth.mockResolvedValueOnce({ state: 'stopped', status: null });
+    mockGetDaemonHealth
+      .mockResolvedValueOnce({ state: 'stopped', status: null })
+      .mockResolvedValueOnce({ state: 'stopped', status: null });
 
     const report = await runBrowserDoctor();
 
@@ -231,7 +237,9 @@ describe('doctor report rendering', () => {
         closeWindow,
       };
     });
-    mockGetDaemonHealth.mockResolvedValueOnce({ state: 'ready', status: { extensionConnected: true } });
+    mockGetDaemonHealth
+      .mockResolvedValueOnce({ state: 'no-extension', status: { extensionConnected: false } })
+      .mockResolvedValueOnce({ state: 'ready', status: { extensionConnected: true } });
 
     await runBrowserDoctor();
 
@@ -328,7 +336,9 @@ describe('doctor report rendering', () => {
 
   it('reads daemon health for the resolved default profile after live connectivity succeeds', async () => {
     mockResolveProfileContextId.mockReturnValue('work');
-    mockGetDaemonHealth.mockResolvedValueOnce({
+    mockGetDaemonHealth
+      .mockResolvedValueOnce({ state: 'no-extension', status: { extensionConnected: false } })
+      .mockResolvedValueOnce({
       state: 'ready',
       status: {
         contextId: 'work',
@@ -350,4 +360,23 @@ describe('doctor report rendering', () => {
       expect.stringContaining('Extension connection is unstable'),
     ]));
   });
+
+  it('does not open a live browser page when selected profile status is already ready', async () => {
+    mockResolveProfileContextId.mockReturnValue('work');
+    mockGetDaemonHealth.mockResolvedValueOnce({
+      state: 'ready',
+      status: {
+        contextId: 'work',
+        extensionConnected: true,
+        extensionVersion: '1.2.3',
+      },
+    });
+
+    const report = await runBrowserDoctor();
+
+    expect(mockGetDaemonHealth).toHaveBeenCalledWith({ contextId: 'work' });
+    expect(mockConnect).not.toHaveBeenCalled();
+    expect(report.connectivity?.ok).toBe(true);
+    expect(report.extensionConnected).toBe(true);
+  });
 });

src/doctor.ts

@@ -100,15 +100,23 @@ export async function checkConnectivity(opts?: { timeout?: number }): Promise<Co
 }
 
 export async function runBrowserDoctor(opts: DoctorOptions = {}): Promise<DoctorReport> {
-  // Live connectivity check is the core of doctor — it doubles as auto-start
-  // (bridge.connect spawns daemon) and validates end-to-end browser bridge health.
-  const connectivity = await checkConnectivity();
-
   // Single status read *after* connectivity side-effects settle. Use the same
   // default/env profile selection as BrowserBridge.connect so multi-profile
   // setups do not report profile-required after the live check succeeds.
   const contextId = resolveProfileContextId();
-  const health = await getDaemonHealth(contextId ? { contextId } : undefined);
+  const healthOpts = contextId ? { contextId } : undefined;
+  const statusStart = Date.now();
+  let health = await getDaemonHealth(healthOpts);
+
+  // If the selected profile is already ready, do not open a temporary page just
+  // to prove connectivity. This keeps doctor read-only for healthy profiles and
+  // avoids creating visible Chrome windows, groups, or blank tabs.
+  const connectivity = health.state === 'ready'
+    ? { ok: true, durationMs: Date.now() - statusStart }
+    : await checkConnectivity();
+  if (health.state !== 'ready') {
+    health = await getDaemonHealth(healthOpts);
+  }
   const daemonRunning = health.state !== 'stopped';
   const extensionConnected = health.state === 'ready';
   const daemonFlaky = connectivity.ok && !daemonRunning;