ForgeAPI seems to not pull latest modpack version

[Hayden-J-C]

Describe the problem

Currently running this docker on unRAID and have MODS_FORGEAPI_RELEASES="Beta" and the project id set to the one for Better Minecraft (482878), the container seems to be pulling v4 instead of v4.5 (latest). I'm wondering if this is just an issue with the forge API not updating or something with the image. Also as a feature request it might be nice in the future if there was someway to poll the API once a day (or a variable interval) to check if the local version is behind the remote, and to update it if so.

[shotah]

Can you re-pull your Minecraft image? I believe I pushed a fix for this 5 days ago. #1451 Let me know if that does work, I can revisit it.

[shotah]

This really has to do with how forgeApi filters the mods, they only filter on major version, I had mistakenly assumed higher IDs meant higher minecraft versions, but if a mod maker keeps deploying for older sub minecraft versions they would be picked up instead. The last fix I pushed now sorts by highest ID, and filters on the full minecraft version.

[Hayden-J-C]

Can you re-pull your Minecraft image? I believe I pushed a fix for this 5 days ago. #1451 Let me know if that does work, I can revisit it.

Image seems to be the latest version, here is a link to the modpack. It does appear that the v4.5 ID is > the v4 ID

[shotah]

3728722 <- v4.5, 3728331 < v4 and they both support 1.18.2, So this really is a forge bug as they do not include a version field for the mod itself.

I can add this to tests and see whats up.

[shotah]

Can you verify you have pulled the latest image? Because latest is working for me.

[init] Resolved version given LATEST into 1.18.2 and major version 1.18
[init] Resolving type given CUSTOM
Downloading https://edge.forgecdn.net/files/3732/702/voicechat-fabric-1.18.2-2.2.32.jar
Downloading https://edge.forgecdn.net/files/3728/616/architectury-4.1.39.jar
Downloading https://edge.forgecdn.net/files/3689/20/fabric-api-0.48.0+1.18.2.jar
Downloading https://edge.forgecdn.net/files/3728/711/Better Minecraft [FORGE] v4.5.zip

[itzg]

@Hayden-J-C if you could run docker container inspect -f '{{json .Config.Labels}}' CONTAINER_ID_OR_NAME, that'll let us confirm you have the latest image with the fix.

[Hayden-J-C]

@Hayden-J-C if you could run docker container inspect -f '{{json .Config.Labels}}' CONTAINER_ID_OR_NAME, that'll let us confirm you have the latest image with the fix.

{
"org.opencontainers.image.authors" : "Geoff Bourne <itzgeoff@gmail.com>",
"org.opencontainers.image.created" : "2022-04-02T20:38:34.183Z",
"org.opencontainers.image.description" : "Docker image that provides a Minecraft Server that will automatically download selected version at `startup",
"org.opencontainers.image.licenses" : "Apache 2.0",
"org.opencontainers.image.revision" : "e0b4a819b1a533609197ef88035ca8f84eab9528",
"org.opencontainers.image.source" : "https://github.com/itzg/docker-minecraft-server",
"org.opencontainers.image.title" : "docker-minecraft-server",
"org.opencontainers.image.url" : "https://github.com/itzg/docker-minecraft-server",
"org.opencontainers.image.version" : "java17"
}

[itzg]

Yep, that's the latest image revision.

[shotah]

@Hayden-J-C so I can better test this, do you have your command or compose file you are using? Because my tests are coming back with the mods.

Thanks!

[itzg]

@Hayden-J-C, if you could add DEBUG=true and provide that out then @shotah can compare with his testing.