butler unexpectedly replaced old channel with new one instead of adding new separate channel on very similar build upload

[hsandt]

Note: this was originally posted on itchio/itch.io#1620 but I realized it should be on butler repo, so reposting here and closing the old issue

Describe the bug
I always prepare a jam-release build followed by a post-jam build for game jams, for archival purpose.

I use different channels for each phase and platform.

Recently, I uploaded on my post-jam channels and discovered it overwrote my jam-release channels unexpectedly. The files are still suffixed jam-release but the version has been upgraded from 0.2.0 to 0.2.1 indeed!

It's the first time it happens, I'm not sure what is different from other jams. I see two things:

• I suspect my changes were minimal (over 99% similarity) and therefore butler tried to guess it was meant to replace the same file as on the old channel, but it wasn't?
• there was a voting period during which uploads were locked, but I tried to upload anyway (to the jam-release channel in an attempt to fix the jam release itself) and it was rejected. I assumed it did nothing, but maybe it somewhat queued the upload for later, and when I tried the second upload it decided to finish the first one but actually overwrite jam-release anyway?

To Reproduce
Steps to reproduce the behavior:

1. Butler push some dummy build file (maybe a text with some very long text) to some jam-release channel
2. Prepare a very similar file (maybe change a character or two, or even none just to test)
3. ? Create a fake jam, make fake game an entry to this jam, and and lock uploads and try an upload to jam-release channel that fails ?
4. Butler push the new file to some post-jam channel
5. Check uploaded files (more details on the edit page): the jam-release channel was removed, the post-jam channel is now replacing it, yet the files are still suffixed with "jam-release"

Expected behavior
Two channels for two files

Screenshots
If applicable, add screenshots to help explain your problem.

butler console log

# butler_push is a custom script but it basically calls butler, in this case on the [platform]-post-jam channels
$ ./butler_push.sh 0.2.1 all
• For channel `windows-post-jam`: last build is 996749, downloading its signature
• Pushing 74.57 MiB (2 files, 1 dirs, 0 symlinks)
✓ Re-used 99.38% of old, added 475.88 KiB fresh data                            
✓ 161.83 KiB patch (99.79% savings)
• Build is now processing, should be up in a bit.

Use the `butler status komehara/downscaled-adventures:windows-post-jam` for more information.

• For channel `macos-post-jam`: last build is 996750, downloading its signature
• Pushing 142.14 MiB (6 files, 4 dirs, 0 symlinks)
✓ Re-used 99.54% of old, added 672.33 KiB fresh data                            
✓ 315.94 KiB patch (99.78% savings)
• Build is now processing, should be up in a bit.

Use the `butler status komehara/downscaled-adventures:macos-post-jam` for more information.

• For channel `linux-post-jam`: last build is 996751, downloading its signature
• Pushing 67.52 MiB (2 files, 1 dirs, 0 symlinks)
✓ Re-used 99.40% of old, added 411.88 KiB fresh data                            
✓ 113.20 KiB patch (99.84% savings)
• Build is now processing, should be up in a bit.

Use the `butler status komehara/downscaled-adventures:linux-post-jam` for more information.

• For channel `web-post-jam`: last build is 996752, downloading its signature
• Pushing 42.76 MiB (9 files, 1 dirs, 0 symlinks)
✓ Re-used 99.04% of old, added 418.28 KiB fresh data                            
✓ 116.39 KiB patch (99.73% savings)
• Build is now processing, should be up in a bit.

Use the `butler status komehara/downscaled-adventures:web-post-jam` for more information.

Resulting uploaded files:

Note the mismatch between the filename and channel name.

Checking status:

$ butler status komehara/downscaled-adventures:web-jam-release
No channel web-jam-release found for komehara/downscaled-adventures
$ butler status komehara/downscaled-adventures:web-post-jam
+--------------+-----------+----------------------------+---------+
|   CHANNEL    |  UPLOAD   |           BUILD            | VERSION |
+--------------+-----------+----------------------------+---------+
| web-post-jam | #10532077 | ✓ #1018939 (from #1018929) | 0.2.1   |
+--------------+-----------+----------------------------+---------+

Desktop (please complete the following information):

• OS: Linux Ubuntu 22.04
• Browser: Chrome Version 126.0.6478.114 (Official Build) (64-bit) (doesn't matter here as upload done via terminal)

$ butler --version
v15.21.0, built on May 11 2021 @ 20:18:40, ref 6ad656e

Additional context
I see my butler is quite old, will try to update.

[leafo]

This is a really weird bug. Haven't trouble identifying what could have happened. Are you sure that you didn't accidentally push the original jam releases to a "post-jam" channel name at the time?

Edit: One question, did you ever upload any files manually from the web interface or have you only used butler?