add istio_feature.proto for feature https://docs.google.com/document/… #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhlsunshine
added
the
release-notes-none
istio-testing
added
the
size/M
| @@ -0,0 +1,48 @@ | |||
| // Copyright 2019 Istio Authors | |||
Contributor
There was a problem hiding this comment.
The year no longer gets included.
Contributor
jacob-delgado
left a comment
jacob-delgado
left a comment
There was a problem hiding this comment.
I feel like there should be a job in test-infra to update this proto when istio/api is updated. I understand that PR is still in-flight. Should the generated proto also be included?
Author
Yes, agree, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to proposal design doc, add proto file for Istio feature management.