Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match LegoCacheSoundManager::~LegoCacheSoundManager #1341

Open
foxtacles opened this issue Jan 17, 2025 · 2 comments
Open

Match LegoCacheSoundManager::~LegoCacheSoundManager #1341

foxtacles opened this issue Jan 17, 2025 · 2 comments

Comments

@foxtacles
Copy link
Member

No description provided.

@disinvite
Copy link
Collaborator

disinvite commented Jan 19, 2025

Looks like the beta used an MxPtrList for this class instead of STL types:

100d0b00 --- LegoCacheSoundEntryList::LegoCacheSoundEntryList
100d0ba0 --- LegoCacheSoundEntryList::Compare
100d0be0 --- MxPtrList<LegoCacheSoundEntry>::MxPtrList<LegoCacheSoundEntry>
100d0c80 --- MxList<LegoCacheSoundEntry *>::MxList<LegoCacheSoundEntry *>
100d0d30 --- MxCollection<LegoCacheSoundEntry *>::MxCollection<LegoCacheSoundEntry *>

(assuming the type is still LegoCacheSoundEntry)

@foxtacles
Copy link
Member Author

Yes - given that fact I think there is a chance that when they refactored it, they did it in the same way as with the classes in the streaming module where they still used a thin proxy class that have functions that merely forward functionality to the STL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants