This repository was archived by the owner on Nov 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Cannot create a pull request from a branch name that contains emoji with the "Compare & Pull request" button #752
Labels
Comments
How did you manage to push a branch called Current git considers that illegal: http://stackoverflow.com/questions/3651860/which-characters-are-illegal-within-a-branch-name |
I didn't push |
Ah OK. Currently, it is possible to merge such a named branch: cirosantilli/test-git-web-interface#21 , but I haven't tried from the create pull request button you mention. But we can only create such branches from the web UI, otherwise a hook rejects the push with:
Unicode in general is alright it seems: https://github.com/cirosantilli/test-git-web-interface/tree/%E4%B8%AD%E6%96%87 |
Similar emoji-handling issues in #816 😢 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Normally when I push a branch I'll see a message like this in my Slack:
Now if I push a branch called ":shower:" I'll see this instead:
And when I go to the home page of my repo it mentions that I pushed branches, but doesn't show the name:
Clicking the "Compare & Pull Request" button doesn't work; I have to manually open a PR for the branch the hard way by looking through the list of all my branches and finding the appropriate one.
Anyways... I don't know the full extent of this issue (whether it extends to unicode characters in general or not). But I would like if GitHub better-supported emoji names for branches since a picture is worth a thousand words, as they say.
The text was updated successfully, but these errors were encountered: