Merge pull request #40 from luis-lab-prs/master

Fix bug #38 - improve tests for shuffle functionality

Author: ross-u

tests/question.spec.js

@@ -80,16 +80,16 @@ describe("Question", () => {
 
     it("should shuffle the items in the 'choices' array", () => {
       // Array with the question choices to be used in the test and passed to the Quiz constructor
-      const testChoices = ["choice1", "choice2", "choice3", "choice4", "choice5"];
+      const testChoices = ["choice1", "choice2", "choice3", "choice4", "choice5", "choice6", "choice7"];
 
       // Instantiate a new Question object with the test choices array
       const question = new Question("test", testChoices, "test");
       // Call the shuffleChoices() method on the Question object
       question.shuffleChoices();
 
       // Check that the 'choices' property of the Question object is not equal to the test choices array (i.e. it has been changed/shuffled)
-      expect(question.choices).not.toEqual(["choice1", "choice2", "choice3", "choice4", "choice5"]);
-      expect(question.choices.length).toEqual(5);
+      expect(question.choices).not.toEqual(["choice1", "choice2", "choice3", "choice4", "choice5", "choice6", "choice7"]);
+      expect(question.choices.length).toEqual(testChoices.length);
     });
   });
 });

tests/quiz.spec.js

@@ -127,15 +127,15 @@ describe("Quiz", () => {
     });
 
     it("should shuffle the items in the 'questions' array", () => {
-        // Array with questions to be used in the test and passed to the Quiz constructor
-      const testQuestions = ["question1", "question2", "question3"];
+      // Array with questions to be used in the test and passed to the Quiz constructor
+      const testQuestions = ["question1", "question2", "question3", "question4", "question5", "question6", "question7"];
       // Instantiate a new Quiz object with the test questions
       const quiz = new Quiz(testQuestions, 60, 60);
       // Call the shuffleQuestions() method to shuffle the questions array in the quiz
       quiz.shuffleQuestions();
       // Check if the questions array is not equal to the original array (it has been changed/shuffled)
-      expect(quiz.questions).not.toEqual(["question1", "question2", "question3"]);
-      expect(quiz.questions.length).toEqual(3);
+      expect(quiz.questions).not.toEqual(["question1", "question2", "question3", "question4", "question5", "question6", "question7"]);
+      expect(quiz.questions.length).toEqual(testQuestions.length);
     });
   });