Datastore Filters

[jmank88]

Follow up from #523

models.AppFilter has a Name string field which is interpreted as an SQL LIKE query. The mock and bolt Datastore implementations use the util.SqlLikeToRegExp function to convert this into an equivalent regexp, but the function is incomplete. As commented, it currently only naively replaces '%', with no '_' or '\'-escape support.

Additionally, models.RouteFilter fields are currently being interpreted only as an exact string comparison, but should probably be treated as LIKE queries as well.

[jmank88]

I just noticed that the only usage (besides tests) of Datastore.GetApps is by api/server/apps_list.go, which always passes in an empty filter. Should this handler be pulling an optional query param into the filter's Name field or something like that? Or can the filter be removed entirely, and the method simplified?

[jmank88]

All current models.RouteFilter usages (actual, and tests-though not all cases covered) assume that fields are static matches, and switching to interpret them all as LIKE queries would break things. Should this filter be left to static match? Or are there cases (like routes_list.go) where users need/want to query for some/image:% or /some/path/prefix/%?