From d1cda03287e481960e6a61192d8b509e437d5a18 Mon Sep 17 00:00:00 2001 From: Hugh Cunningham Date: Wed, 12 Feb 2025 11:47:50 -0800 Subject: [PATCH] removes ledger flag from 'wallet:multisig:participant:create' there is no longer a need to "create" the participant identity from the Ledger device by importing it into the walletDB since our CLI commands now read the identity directly from the Ledger when needed removes the '--ledger' flag from the command and thereby removes the call to importParticipant Closes IFL-3168 --- .../wallet/multisig/participant/create.ts | 29 +------------------ 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/ironfish-cli/src/commands/wallet/multisig/participant/create.ts b/ironfish-cli/src/commands/wallet/multisig/participant/create.ts index 3a609a8a97..c875f8f1b4 100644 --- a/ironfish-cli/src/commands/wallet/multisig/participant/create.ts +++ b/ironfish-cli/src/commands/wallet/multisig/participant/create.ts @@ -5,7 +5,6 @@ import { RPC_ERROR_CODES, RpcRequestError } from '@ironfish/sdk' import { Flags } from '@oclif/core' import { IronfishCommand } from '../../../../command' import { RemoteFlags } from '../../../../flags' -import { LedgerMultiSigner } from '../../../../ledger' import * as ui from '../../../../ui' export class MultisigIdentityCreate extends IronfishCommand { @@ -17,10 +16,6 @@ export class MultisigIdentityCreate extends IronfishCommand { char: 'n', description: 'Name to associate with the identity', }), - ledger: Flags.boolean({ - default: false, - description: 'Perform operation with a ledger device', - }), } async start(): Promise { @@ -34,22 +29,10 @@ export class MultisigIdentityCreate extends IronfishCommand { name = await ui.inputPrompt('Enter a name for the identity', true) } - let identity - if (flags.ledger) { - identity = await this.getIdentityFromLedger() - } - let response while (!response) { try { - if (identity) { - response = await client.wallet.multisig.importParticipant({ - name, - identity: identity.toString('hex'), - }) - } else { - response = await client.wallet.multisig.createParticipant({ name }) - } + response = await client.wallet.multisig.createParticipant({ name }) } catch (e) { if ( e instanceof RpcRequestError && @@ -68,14 +51,4 @@ export class MultisigIdentityCreate extends IronfishCommand { this.log('Identity:') this.log(response.content.identity) } - - async getIdentityFromLedger(): Promise { - const ledger = new LedgerMultiSigner() - - return ui.ledger({ - ledger, - message: 'Getting Ledger Identity', - action: () => ledger.dkgGetIdentity(0), - }) - } }