Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat history + Channel rename #532

Open
progval opened this issue Sep 16, 2023 · 3 comments
Open

Chat history + Channel rename #532

progval opened this issue Sep 16, 2023 · 3 comments

Comments

@progval
Copy link
Contributor

progval commented Sep 16, 2023

https://ircv3.net/specs/extensions/channel-rename does not specify how it interacts with chathistory and event-playback. Open questions:

  1. should RENAME appear in the history? if yes, conditioned to what capabilities?
  2. should the old name appear in the history as message targets? if yes, conditioned to what capabilities?

Ergo choses to answer "no" to both questions, meaning that to clients it looks like the channel had always had the new name. Matrix2051 answers no to the second question, and I probably yes to the first, which is an "unexpected feature".

Example with Ergo:

user -> S:   PRIVMSG #oldchan :let's rename it
S -> chanop: :[email protected] PRIVMSG #oldchan :let's rename it
chanop -> S: RENAME #oldchan #newchan :no reason
S -> chanop: :[email protected] RENAME #oldchan #newchan :no reason
S -> user:   :[email protected] RENAME #oldchan #newchan :no reason
user -> S:   PRIVMSG #newchan :nice new name
user -> S:   CHATHISTORY LATEST #newchan * 10
S -> user:   :[email protected] JOIN #newchan
S -> user:   :[email protected] JOIN #newchan
S -> user:   :[email protected] PRIVMSG #newchan :let's rename it
S -> user:   :[email protected] PRIVMSG #newchan :nice new name
@progval
Copy link
Contributor Author

progval commented Sep 16, 2023

@jwheare's opinion:

  1. yes, conditioned to draft/channel-rename and draft/event-playback caps
  2. no, ie.
:[email protected] PRIVMSG #newchan :let's rename it
:[email protected] RENAME #oldchan #newchan :no reason
:[email protected] PRIVMSG #newchan :nice new name

@spb
Copy link

spb commented Sep 16, 2023

Is the "no" to 2. a "no, it isn't worth spending the effort to do this", or "no, this would be the wrong thing and should be avoided even if it's easier"?

@spb
Copy link

spb commented May 11, 2024

@jwheare's opinion:

1. yes, conditioned to `draft/channel-rename` and `draft/event-playback` caps

2. no, ie.
:[email protected] PRIVMSG #newchan :let's rename it
:[email protected] RENAME #oldchan #newchan :no reason
:[email protected] PRIVMSG #newchan :nice new name

If we're going down the route of always using the channel's current name in history playback, what should happen if the channel has emptied, been destroyed, and a new channel created (or worse, renamed) using the last name it had? Those are two distinct targets that shouldn't have their history interleaved, so how do you refer to them both (both in TARGETS and in message playback)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants