Separate pure HTTP client services from logical services

[JulienMessageIppon]

Description

• in the service folder, some services call other services (AWSDataCenterService calls infrastructureService for example) which can lead to confusion.
• Some services use ofetch, others extend HttpService

Objective

• at least two folders : clients for HTTP clients, services for logical services that eventually call HTTP clients. Internal organization of those folders can be added for clarity.
• coherence between HttpService and ofetch

Acceptance

• HTTP clients are separated from the rest of the files and use the same Http client everywhere

[JulienMessageIppon]

Proposal

1. Organize the clients in separate folders according to the backend it will call (Iroco2, AWS, Authentication provider) and then by the Uri it will call (calls to /analysis will be in an "analysis" folder)
2. Put types that are only used in these clients in the same folders as their client
3. Strongly type clients' functions' signature with types from the domain

[JulienMessageIppon]

Services that call other services:

• AWSDataCenterService use two other services, one of them is useless

Services with embedded logic:

• AnalysisService calls convertEstimateToBestMassUnit and others
• AWSDataCenterService calls a store
• IrocalcCarbonService do maths
• CatalogService sorts stuff that should be sorted in the backend or on display
• CloudServiceProviderSvc calls a store
• ScanService do smart conversions

Recommendation: rename the services "apiClient" or anything when they're de-correlated from any business calculation. Then split the remaining services between an apiClient and another service calling it