Skip to content

Commit 253f8fd

Browse files
committed
build: keep afterSign enabled only for macOS packaging
Remove afterSign from the shared electron-builder config so Linux builds do not print the no-signing warning. Keep notarization active for macOS release builds by passing afterSign only on the macOS CI build.
1 parent 70fc0a9 commit 253f8fd

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ jobs:
225225
with:
226226
package_manager: npm
227227
skip_package_manager_install: true
228-
args: --publish onTagOrDraft # attach signed binaries to an existing release draft or when a tag is merged
228+
args: --publish onTagOrDraft ${{ matrix.os == 'macos-latest' && '-c.afterSign=./pkgs/macos/notarize-build.js' || '' }} # attach signed binaries to an existing release draft or when a tag is merged
229229
release: false # keep github release as draft for manual inspection
230230
max_attempts: 2
231231
# GH token for attaching atrifacts to release draft on tag build
@@ -262,4 +262,3 @@ jobs:
262262

263263
- name: Show Cache
264264
run: du -sh ${{ github.workspace }}/.cache/ && ls -l ${{ github.workspace }}/.cache/
265-

electron-builder.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ directories:
1313

1414
asarUnpack: 'src/**/scripts/**/*'
1515

16-
afterSign: './pkgs/macos/notarize-build.js'
17-
1816
mac:
1917
artifactName: ${name}-${version}-squirrel.${ext}
2018
category: public.app-category.utilities

0 commit comments

Comments
 (0)