Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input to WrapObject #22

Open
Stebalien opened this issue Jul 14, 2017 · 0 comments
Open

Validate input to WrapObject #22

Stebalien opened this issue Jul 14, 2017 · 0 comments

Comments

@Stebalien
Copy link
Member

The CBOR library is smart and will try to serialize arbitrary types using reflection. Unfortunately, this makes it very easy to introduce silent bugs.

For example, the following does not panic. Instead, cbor just uses reflection to serialize child.

child, _ := WrapObject("thing")
parent, err := WrapObject(map[string]interface{}{
    "child": child, // missing a call to `.Cid()`
})

if err != nil {
    panic(err)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant