Apply suggestions from code review

Co-Authored-By: Phoenix <[email protected]>

Author: lzpap

iota/adapter/__init__.py

@@ -153,7 +153,7 @@ class BaseAdapter(object, metaclass=AdapterMeta):
     def __init__(self) -> None:
         super(BaseAdapter, self).__init__()
 
-        self._logger: Logger = None
+        self._logger: Optional[Logger] = None
         self.local_pow: bool = False
 
     @abstract_method
@@ -166,7 +166,7 @@ def get_uri(self) -> Text:
         )
 
     @abstract_method
-    def send_request(self, payload: Dict, **kwargs: Dict) -> Dict:
+    def send_request(self, payload: Dict, **kwargs: Any) -> Dict:
         """
         Sends an API request to the node.
 
@@ -200,7 +200,7 @@ def _log(
             self,
             level: int,
             message: Text,
-            context: Optional[int] = None
+            context: Optional[dict] = None
     ) -> None:
         """
         Sends a message to the instance's logger, if configured.
@@ -263,7 +263,7 @@ def __init__(
             self,
             uri: Union[Text, SplitResult],
             timeout: Optional[int] = None,
-            authentication: Optional[Dict] = None
+            authentication: Optional[Tuple[Text, Text]] = None
     ) -> None:
         super(HttpAdapter, self).__init__()
 
@@ -325,7 +325,7 @@ def node_url(self) -> Text:
     def get_uri(self) -> Text:
         return self.uri.geturl()
 
-    async def send_request(self, payload: Dict, **kwargs: Dict) -> Dict:
+    async def send_request(self, payload: Dict, **kwargs: Any) -> Dict:
         kwargs.setdefault('headers', {})
         for key, value in self.DEFAULT_HEADERS.items():
             kwargs['headers'].setdefault(key, value)
@@ -406,7 +406,7 @@ def _interpret_response(
             self,
             response: Response,
             payload: Dict,
-            expected_status: Container[Dict]
+            expected_status: Container[int]
     ) -> Dict:
         """
         Interprets the HTTP response from the node.
@@ -584,7 +584,7 @@ def seed_response(self, command: Text, response: Dict) -> 'MockAdapter':
         self.responses[command].append(response)
         return self
 
-    async def send_request(self, payload: Dict, **kwargs: Dict) -> Dict:
+    async def send_request(self, payload: Dict, **kwargs: Any) -> Dict:
         """
         Mimic asynchronous behavior of `HttpAdapter.send_request`.
         """

iota/adapter/wrappers.py

@@ -26,7 +26,7 @@ def get_uri(self) -> Text:
         return self.adapter.get_uri()
 
     @abstract_method
-    def send_request(self, payload: Dict, **kwargs: Dict) -> Dict:
+    def send_request(self, payload: Dict, **kwargs: Any) -> Dict:
         raise NotImplementedError(
             'Not implemented in {cls}.'.format(cls=type(self).__name__),
         )
@@ -131,7 +131,7 @@ def get_adapter(self, command: Text) -> BaseAdapter:
         """
         return self.routes.get(command, self.adapter)
 
-    async def send_request(self, payload: Dict, **kwargs: Dict) -> Dict:
+    async def send_request(self, payload: Dict, **kwargs: Any) -> Dict:
         command = payload.get('command')
 
         return await self.get_adapter(command).send_request(payload, **kwargs)

iota/codecs.py

@@ -59,11 +59,12 @@ def get_codec_info(cls) -> CodecInfo:
         """
         codec = cls()
 
-        # In Python 2, all codecs are made equal.
-        # In Python 3, some codecs are more equal than others
         codec_info = {
             'encode': codec.encode,
             'decode': codec.decode,
+            
+            # In Python 2, all codecs are made equal.
+            # In Python 3, some codecs are more equal than others.
             '_is_text_encoding': False
         }
 

iota/commands/__init__.py

@@ -34,8 +34,8 @@ def __init__(self, adapter: BaseAdapter) -> None:
     self.adapter = adapter
 
     self.called: bool = False
-    self.request: Dict = None
-    self.response: Dict = None
+    self.request: Optional[Dict] = None
+    self.response: Optional[Dict] = None
 
   async def __call__(self, **kwargs: Any) -> Dict:
     """
@@ -262,4 +262,4 @@ def _apply_filter(
           },
         )
 
-    return value
+    return value

iota/crypto/kerl/conv.py

@@ -91,7 +91,7 @@ def convertBytesToBigInt(ba: List[int]) -> int:
                enumerate(reversed(bytesArray))) * signum
 
 
-def convertBigintToBytes(big: int) -> List[int]:
+def convertBigIntToBytes(big: int) -> List[int]:
     bytesArrayTemp = [(abs(big) >> pos * 8) % (1 << 8) for pos in
                       range(48)]
 

iota/crypto/signing.py

@@ -256,7 +256,7 @@ def __init__(
             )
 
         # In order to work correctly, the seed must be padded so that it
-        # is a    multiple of 81 trytes.
+        # is a multiple of 81 trytes.
         seed += b'9' * (Hash.LEN - ((len(seed) % Hash.LEN) or Hash.LEN))
 
         self.security_level = security_level

iota/multisig/commands/get_digests.py

@@ -30,7 +30,7 @@ def get_response_filter(self):
 
     # There is no async operation going on here, but the base class is async,
     # so from the outside, we have to act like we are doing async.
-    async def _execute(self, request: Dict):
+    async def _execute(self, request: Dict) -> Dict:
         count: Optional[int] = request['count']
         index: int = request['index']
         seed: Seed = request['seed']

iota/multisig/commands/get_private_keys.py

@@ -31,7 +31,7 @@ def get_response_filter(self):
 
     # There is no async operation going on here, but the base class is async,
     # so from the outside, we have to act like we are doing async.
-    async def _execute(self, request: Dict):
+    async def _execute(self, request: Dict) -> Dict:
         count: Optional[int] = request['count']
         index: int = request['index']
         seed: Seed = request['seed']

iota/multisig/commands/prepare_multisig_transfer.py

@@ -31,7 +31,7 @@ def get_request_filter(self) -> 'PrepareMultisigTransferRequestFilter':
     def get_response_filter(self):
         pass
 
-    async def _execute(self, request: Dict):
+    async def _execute(self, request: Dict) -> Dict:
         change_address: Optional[Address] = request['changeAddress']
         multisig_input: MultisigAddress = request['multisigInput']
         transfers: List[ProposedTransaction] = request['transfers']

iota/transaction/base.py

@@ -214,7 +214,7 @@ def __init__(
         :type: :py:class:`TransactionHash`
         """
 
-        self.bundle_hash: BundleHash = bundle_hash
+        self.bundle_hash: Optional[BundleHash] = bundle_hash
         """
         The bundle hash, used to identify transactions that are part of the same
         bundle.
@@ -249,7 +249,7 @@ def __init__(
         :type: ``int``
         """
 
-        self._legacy_tag: Tag = legacy_tag
+        self._legacy_tag: Optional[Tag] = legacy_tag
         """
         A short message attached to the transaction.
 
@@ -259,7 +259,7 @@ def __init__(
         :type: :py:class:`Tag`
         """
 
-        self.nonce: Nonce = nonce
+        self.nonce: Optional[Nonce] = nonce
         """
         Unique value used to increase security of the transaction hash.
 
@@ -281,7 +281,7 @@ def __init__(
         :type: ``int``, unix timestamp in seconds.
         """
 
-        self.current_index: int = current_index
+        self.current_index: Optional[int] = current_index
         """
         The position of the transaction inside the bundle.
 
@@ -295,7 +295,7 @@ def __init__(
         :type: ``int``
         """
 
-        self.last_index: int = last_index
+        self.last_index: Optional[int] = last_index
         """
         The index of the final transaction in the bundle.
 
@@ -305,7 +305,7 @@ def __init__(
         :type: ``int``
         """
 
-        self.trunk_transaction_hash: TransactionHash = trunk_transaction_hash
+        self.trunk_transaction_hash: Optional[TransactionHash] = trunk_transaction_hash
         """
         The transaction hash of the next transaction in the bundle.
 
@@ -319,7 +319,7 @@ def __init__(
         :type: :py:class:`TransactionHash`
         """
 
-        self.branch_transaction_hash: TransactionHash = branch_transaction_hash
+        self.branch_transaction_hash: Optional[TransactionHash] = branch_transaction_hash
         """
         An unrelated transaction that this transaction "approves".
 
@@ -334,7 +334,7 @@ def __init__(
         :type: :py:class:`TransactionHash`
         """
 
-        self.tag: Tag = tag
+        self.tag: Optional[Tag] = tag
         """
         Optional classification tag applied to this transaction.
 
@@ -343,7 +343,7 @@ def __init__(
         :type: :py:class:`Tag`
         """
 
-        self.attachment_timestamp: int = attachment_timestamp
+        self.attachment_timestamp: Optional[int] = attachment_timestamp
         """
         Estimated epoch time of the attachment to the tangle.
 
@@ -352,21 +352,21 @@ def __init__(
         :type: ``int``, unix timestamp in milliseconds,
         """
 
-        self.attachment_timestamp_lower_bound: int = attachment_timestamp_lower_bound
+        self.attachment_timestamp_lower_bound: Optional[int] = attachment_timestamp_lower_bound
         """
         The lowest possible epoch time of the attachment to the tangle.
 
         :type: ``int``, unix timestamp in milliseconds.
         """
 
-        self.attachment_timestamp_upper_bound: int = attachment_timestamp_upper_bound
+        self.attachment_timestamp_upper_bound: Optional[int] = attachment_timestamp_upper_bound
         """
         The highest possible epoch time of the attachment to the tangle.
 
         :type: ``int``, unix timestamp in milliseconds.
         """
 
-        self.signature_message_fragment: Fragment = signature_message_fragment
+        self.signature_message_fragment: Optional[Fragment] = signature_message_fragment
         """
         "Signature/Message Fragment" (note the slash):