Skip to content

Commit c235b79

Browse files
revert: fix(ion-button): sync disabled state in ion-button renderHiddenButton
This reverts commit 1d4c704. Will retest changes without the fix and new test location
1 parent 31aff31 commit c235b79

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

core/src/components/button/button.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,13 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
195195

196196
/**
197197
* If the form already has a rendered form button
198-
* then do not append a new one again.
198+
* then do not append a new one again. Sync the
199+
* disabled state and type in it changes after button
200+
* creation (e.g., runtime property updates).
199201
*/
200202
if (formButtonEl !== null && formEl.contains(formButtonEl)) {
201-
formButtonEl.disabled = this.disabled;
203+
// formButtonEl.disabled = this.disabled;
204+
// formButtonEl.type = this.type;
202205
return;
203206
}
204207

0 commit comments

Comments
 (0)