Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

war3mapUnits.doo changed, format version not changed #10

Open
WaterKnight opened this issue Nov 3, 2023 · 1 comment
Open

war3mapUnits.doo changed, format version not changed #10

WaterKnight opened this issue Nov 3, 2023 · 1 comment

Comments

@WaterKnight
Copy link
Contributor

External URLs

https://us.forums.blizzard.com/en/warcraft3/t/war3mapunitsdoo-changed-format-version-not-changed/29081

Summary

The format of the war3mapUnits.doo file inside map archives has been changed as of 1.32 to additionally feature a “skinId” attribute per unit/item object. But the version/sub version numbers after the “W3do” start marker have not been increased, i.e., to parse the file properly, additional context information is needed now, i.e., one needs to know what game version the war3mapUnits.doo was saved with as found in the war3map.w3i.

Description

This breaks existing libraries/tooling which handle war3mapUnits.doo as a standalone file.

Expected

The format version should be increased to indicate the different format. If the indication should now be using the war3map.w3i in general instead, then at least change the specified format version in the war3mapUnits.doo one last time, maybe to 0x0 in order to indicate that it is not self-sufficient anymore and in order to not break backwards compatibility.

Actual

No response

Reproduction steps

No response

Workaround

No response

Screenshots

No response

Game Versions

1.33.0 (1.33.0.18931, 1.33.0.19010, 1.33.0.19019, 1.33.0.19089, 1.33.0.19308)

@cipherxof
Copy link

Even maps with format version 25 (TFT) can use Reforged doo files as can be seen here: https://cdn.discordapp.com/attachments/1037954156708773929/1053586405441417266/DotA_LoD_2.1e1.w3x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants