Need a way to remove an item from Holdings

[fenderwhite]

I created a portfolio, then added a transaction(buy) for a test.

Then I removed the transaction(buy) by "delete transaction".

However, the item is still shown in the Holdings section, and I cannot remove it from the list(portfolio).

Attached is the screenshot, and the symbol "294400.KS" is the problem.

[hackeresq]

This was kinda intentional on my part. I wanted to see what I used to own.

In your case since you were just testing I can see why you'd want to delete the holding.

This will require some logic to check for any other transactions when deleting. If no other transactions, delete the accompanying holding. Should be a quick add in deleting() event on the Transaction model.

Want to give it a shot?

[fenderwhite]

Yeah, I want to give it a shot.

[fenderwhite]

BTW, as you said, it is sometimes necessary to check what I used to own.
But for this purpose, those 0 stock items should stay in the list only when I bought a certain amount, and then I finally came to sell all of them. => Which means, there should be all BUY transactions and SELL transactions of the stock.
However, in my case, there were only BUY transactions (with no SELL transactions), and deletion of the transactions. => In this case, I think it is kinda more natural to just remove the stock name from the list of portfolio.
This just my idea. :)

[hackeresq]

Sounds right to me.

If there's no related transactions, the holding should be deleted.

That can probably be a check in the syncHoldings method on the Transactions model.

Let me know if you need more help to point you in the right direction!