Skip to content

feat: add placeholder support to empty lists of applied controls in selector #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: add placeholder support to empty lists of applied controls in selector #2882

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7ab7ea
added placeholder support to empty lists of applied controls in selec…
tchoumi313 Nov 17, 2025
ed03560
Merge branch 'main' into CA-1383-add-a-placeholder-in-empty-lists-of-…
tchoumi313 Nov 20, 2025
9dd4fc6
Merge branch 'main' into CA-1383-add-a-placeholder-in-empty-lists-of-…
tchoumi313 Nov 20, 2025
22e7644
Merge branch 'CA-1383-add-a-placeholder-in-empty-lists-of-applied-con…
tchoumi313 Nov 20, 2025
0e2726b
update
tchoumi313 Nov 24, 2025
2e84f52
update
tchoumi313 Nov 24, 2025
6b12378
Merge branch 'main' into CA-1383-add-a-placeholder-in-empty-lists-of-…
tchoumi313 Nov 24, 2025
cb11fd8
Merge branch 'main' into CA-1383-add-a-placeholder-in-empty-lists-of-…
tchoumi313 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2670,5 +2670,6 @@
"doraAlternativeProviders": "Alternative Providers",
"doraAttributes": "DORA Attributes",
"doraAssessment": "DORA Assessment",
"moreOnTerminologiesHelpText": "Hint: more options can be defined through terminologies"
"moreOnTerminologiesHelpText": "Hint: more options can be defined through terminologies",
"selectExistingAppliedControls": "Select existing applied controls..."
}
3 changes: 2 additions & 1 deletion frontend/messages/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2670,5 +2670,6 @@
"webhookEndpointUrlHelpText": "L'URL où l'application recevra les webhooks entrants du service tiers.",
"webhookSecret": "Secret webhook",
"webhookSecretAlreadySetHelpText": "Le secret webhook est déjà défini.",
"webhookUrl": "URL webhook"
"webhookUrl": "URL webhook",
"selectExistingAppliedControls": "Sélectionnez des mesures appliquées existantes..."
}
3 changes: 3 additions & 0 deletions frontend/src/lib/components/Forms/AutocompleteSelect.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
disabled?: boolean;
hidden?: boolean;
translateOptions?: boolean;
placeholder?: string | null;
options?: Option[];
optionsEndpoint?: string;
optionsDetailedUrlParameters?: [string, string][];
Expand Down Expand Up @@ -88,6 +89,7 @@
disabled = false,
hidden = false,
translateOptions = true,
placeholder = null,
options = [],
optionsEndpoint = '',
optionsDetailedUrlParameters = [],
Expand Down Expand Up @@ -457,6 +459,7 @@
duplicates={false}
key={JSON.stringify}
filterFunc={fastFilter}
{placeholder}
>
{#snippet option({ option })}
{#if optionSnippet}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/lib/components/Forms/ModelForm/FindingForm.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
optionsExtraFields={[['folder', 'str']]}
field="applied_controls"
label={m.appliedControls()}
placeholder={m.selectExistingAppliedControls()}
/>
{/key}
</div>
Expand Down
1 change: 1 addition & 0 deletions frontend/src/lib/components/Forms/ModelForm/SecurityExceptionForm.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@
optionsExtraFields={[['folder', 'str']]}
field="applied_controls"
label={m.appliedControls()}
placeholder={m.selectExistingAppliedControls()}
/>
{/key}
</div>
Expand Down
1 change: 1 addition & 0 deletions frontend/src/lib/components/Forms/ModelForm/StakeholderForm.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@
optionsExtraFields={[['folder', 'str']]}
field="applied_controls"
label={m.appliedControls()}
placeholder={m.selectExistingAppliedControls()}
/>
</div>
<div class="flex items-end">
Expand Down
1 change: 1 addition & 0 deletions frontend/src/lib/components/Forms/ModelForm/TaskTemplateForm.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@
optionsExtraFields={[['folder', 'str']]}
field="applied_controls"
label={m.appliedControls()}
placeholder={m.selectExistingAppliedControls()}
/>
<AutocompleteSelect
multiple
Expand Down
1 change: 1 addition & 0 deletions frontend/src/lib/components/Forms/ModelForm/VulnerabilitiesForm.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
optionsExtraFields={[['folder', 'str']]}
field="applied_controls"
label={m.appliedControls()}
placeholder={m.selectExistingAppliedControls()}
/>
<AutocompleteSelect
{form}
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@
field="existing_applied_controls"
label={m.existingControls()}
helpText={m.existingControlsHelper()}
placeholder={m.selectExistingAppliedControls()}
/>
{/key}
</div>
Expand Down Expand Up @@ -380,6 +381,7 @@
field="applied_controls"
label={m.extraAppliedControls()}
helpText={m.extraControlsHelper()}
placeholder={m.selectExistingAppliedControls()}
/>
{/key}
</div>
Expand Down
1 change: 1 addition & 0 deletions frontend/src/routes/(app)/(third-party)/requirement-assessments/[id=uuid]/edit/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@
]}
optionsExtraFields={[['folder', 'str']]}
field="applied_controls"
placeholder={m.selectExistingAppliedControls()}
/>
{/key}
<ModelTable
Expand Down
Loading